Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some methods have been changed #1222

Open
90 tasks
ablearthy opened this issue Feb 9, 2022 · 5 comments · Fixed by #1600
Open
90 tasks

Some methods have been changed #1222

ablearthy opened this issue Feb 9, 2022 · 5 comments · Fixed by #1600
Labels
Задача Задача требующая реализации нового или доработке существующего функционала
Milestone

Comments

@ablearthy
Copy link

ablearthy commented Feb 9, 2022

I used VK API JSON Schema, so that some methods don't exist in schema but it's easy to find them here.

  • ### account.getCounters
    Link: https://dev.vk.com/method/account.getCounters Real fields: filter, user_id Actual fields: filter +user_id

  • ### ads.getCampaigns
    Link: https://dev.vk.com/method/ads.getCampaigns Real fields: fields, client_id, account_id, campaign_ids, include_deleted Actual fields: campaign_ids, client_id, account_id, include_deleted +fields

  • ### ads.getStatistics
    Link: https://dev.vk.com/method/ads.getStatistics Real fields: ids, stats_fields, account_id, date_from, date_to, ids_type, period Actual fields: ids, account_id, date_from, date_to, ids_type, period +stats_fields

  • ### ads.getTargetingStats
    Link: https://dev.vk.com/method/ads.getTargetingStats Real fields: impressions_limit_period, publisher_platforms, ad_format, ad_platform_no_wall, link_domain, need_precise, client_id, ad_id, account_id, ad_platform, criteria, ad_platform_no_ad_network, link_url Actual fields: ad_platform, link_domain, ad_format, client_id, account_id, ad_id, ad_platform_no_wall, criteria, link_url +impressions_limit_period +publisher_platforms (failed to find it on the website) +need_precise +ad_platform_no_ad_network

  • ### apps.getFriendsList
    Link: https://dev.vk.com/method/apps.getFriendsList Real fields: fields, count, extended, type, offset Actual fields: extended, type, offset, fields +count

  • ### board.getComments
    Link: https://dev.vk.com/method/board.getComments Real fields: count, group_id, extended, sort, offset, need_likes, topic_id, start_comment_id Actual fields: count, group_id, extended, sort, offset, preview_length, need_likes, topic_id, start_comment_id -preview_length

  • ### docs.get
    Link: https://dev.vk.com/method/docs.get Real fields: return_tags, count, type, owner_id, offset Actual fields: count, offset, type, owner_id +return_tags

  • ### docs.getById
    Link: https://dev.vk.com/method/docs.getById Real fields: docs, return_tags Actual fields: docs +return_tags

  • ### docs.getMessagesUploadServer
    Link: https://dev.vk.com/method/docs.getMessagesUploadServer Real fields: type, peer_id Actual fields: group_id, type +peer_id -group_id

  • ### docs.save
    Link: https://dev.vk.com/method/docs.save Real fields: file, tags, return_tags, title Actual fields: file, tags, title +return_tags

  • ### docs.search
    Link: https://dev.vk.com/method/docs.search Real fields: return_tags, count, q, search_own, offset Actual fields: q, count, search_own, offset +return_tags

  • ### fave.addArticle
    Link: https://dev.vk.com/method/fave.addArticle Real fields: url Actual fields: ref, source, track_code, url -ref -source -track_code

  • ### fave.addPost
    Link: https://dev.vk.com/method/fave.addPost Real fields: access_key, id, owner_id (well, everything is ok with this method except that in schema there's no source, track_code, ref, while these fields exist) Actual fields: source, id, owner_id, ref, access_key, track_code

  • ### fave.addProduct
    Link: https://dev.vk.com/method/fave.addProduct Real fields: access_key, id, owner_id Actual fields: source, id, owner_id, ref, access_key -source -ref

  • ### fave.addVideo
    Link: https://dev.vk.com/method/fave.addVideo Real fields: access_key, id, owner_id Actual fields: ref, access_key, id, owner_id -ref

  • ### fave.removeArticle
    Link: https://dev.vk.com/method/fave.removeArticle Real fields: article_id, owner_id (see fave.addPost) Actual fields: ref, article_id, owner_id

  • ### fave.removeLink
    Link: https://dev.vk.com/method/fave.removeLink Real fields: link_id, link (link field doesn't exist on the website) Actual fields: link_id +link

  • ### friends.getRequests
    Link: https://dev.vk.com/method/friends.getRequests Real fields: need_viewed, fields, count, need_mutual, extended, sort, ref, suggested, offset, out Actual fields: need_viewed, count, need_mutual, extended, sort, suggested, offset, out +ref +fields

  • ### friends.getRequests
    Link: https://dev.vk.com/method/friends.getRequests Real fields: need_viewed, fields, count, need_mutual, extended, sort, ref, suggested, offset, out Actual fields: need_viewed, count, need_mutual, extended, sort, suggested, offset, out +ref +fields

  • ### groups.create
    Link: https://dev.vk.com/method/groups.create Real fields: title, public_subcategory, subtype, type, public_category, description Actual fields: subtype, type, description, title +public_category +public_subcategory

  • ### groups.edit
    Link: https://dev.vk.com/method/groups.edit Real fields: market_wiki, title, messages, public_date, public_subcategory, phone, docs, obscene_stopwords, market_comments, places, event_group_id, website, wiki, rss, main_section, contacts, event_start_date, obscene_filter, addresses, city, access, description, topics, wall, links, market, events, subject, email, video, obscene_words, country, screen_name, age_limits, articles, market_country, secondary_section, photos, group_id, market_currency, audio, market_city, public_category, market_contact, event_finish_date Actual fields: market_wiki, title, messages, public_date, public_subcategory, phone, docs, obscene_stopwords, places, event_group_id, website, wiki, rss, main_section, contacts, event_start_date, obscene_filter, addresses, city, access, description, topics, wall, links, market, events, subject, email, video, obscene_words, country, screen_name, age_limits, articles, secondary_section, photos, group_id, audio, public_category, event_finish_date +market_country +market_currency +market_comments +market_city +market_contact

  • ### groups.isMember
    Link: https://dev.vk.com/method/groups.isMember Real fields: group_id, extended, user_id, user_ids Actual fields: group_id, extended, user_ids +user_id

  • ### groups.setLongPollSettings
    Link: https://dev.vk.com/method/groups.setLongPollSettings Real fields: wall_repost, board_post_delete, group_leave, message_reply, video_new, board_post_restore, market_comment_restore, video_comment_edit, video_comment_new, audio_new, photo_comment_new, message_edit, wall_reply_delete, photo_comment_delete, enabled, user_block, wall_reply_new, message_typing_state, group_change_settings, donut_money_withdraw_error, donut_money_withdraw, group_change_photo, group_officers_edit, api_version, user_unblock, video_comment_restore, market_comment_delete, message_allow, wall_post_new, photo_new, message_deny, donut_subscription_create, board_post_new, market_comment_new, message_event, donut_subscription_price_changed, donut_subscription_expired, market_comment_edit, donut_subscription_prolonged, donut_subscription_cancelled, wall_reply_edit, group_join, group_id, video_comment_delete, message_new, like_add, wall_reply_restore, like_remove, photo_comment_restore, poll_vote_new, board_post_edit, photo_comment_edit Actual fields: wall_repost, board_post_delete, group_leave, message_reply, video_new, board_post_restore, market_comment_restore, video_comment_edit, video_comment_new, audio_new, photo_comment_new, message_edit, wall_reply_delete, photo_comment_delete, enabled, user_block, wall_reply_new, message_typing_state, group_change_settings, group_change_photo, group_officers_edit, api_version, user_unblock, video_comment_restore, market_comment_delete, message_allow, wall_post_new, photo_new, message_deny, board_post_new, market_comment_new, market_comment_edit, wall_reply_edit, group_join, group_id, video_comment_delete, message_new, wall_reply_restore, photo_comment_restore, poll_vote_new, board_post_edit, photo_comment_edit +donut_subscription_price_changed +donut_subscription_expired +donut_subscription_prolonged +donut_subscription_cancelled +donut_money_withdraw_error +like_add +like_remove +donut_subscription_create +message_event +donut_money_withdraw

  • ### groups.unban
    Link: https://dev.vk.com/method/groups.unban Real fields: group_id, owner_id Actual fields: group_id, user_id +owner_id -user_id

  • ### likes.add
    Link: https://dev.vk.com/method/likes.add Real fields: access_key, type, item_id, owner_id Actual fields: item_id, type, owner_id, ref, access_key -ref

  • ### likes.delete
    Link: https://dev.vk.com/method/likes.delete Real fields: access_key, type, item_id, owner_id Actual fields: type, item_id, owner_id +access_key

  • ### market.add
    Link: https://dev.vk.com/method/market.add Real fields: price, dimension_length, deleted, name, old_price, sku, main_photo_id, photo_ids, category_id, url, dimension_width, owner_id, dimension_height, weight, description Actual fields: price, item_id, deleted, name, main_photo_id, photo_ids, category_id, url, owner_id, description +dimension_length +old_price +sku +dimension_height +dimension_width +weight

  • ### market.addToAlbum
    Link: https://dev.vk.com/method/market.addToAlbum Real fields: item_ids, album_ids, owner_id Actual fields: album_ids, item_id, owner_id +item_ids

  • ### messages.addChatUser
    Link: https://dev.vk.com/method/messages.addChatUser Real fields: user_id, visible_messages_count, chat_id Actual fields: user_id, chat_id +visible_messages_count

  • ### messages.createChat
    Link: https://dev.vk.com/method/messages.createChat Real fields: group_id, user_ids, title Actual fields: user_ids, title +group_id

  • ### messages.delete
    Link: https://dev.vk.com/method/messages.delete Real fields: delete_for_all, peer_id, group_id, message_ids, spam, cmids Actual fields: delete_for_all, peer_id, conversation_message_ids, group_id, message_ids, spam +cmids -conversation_message_ids

  • ### messages.edit
    Link: https://dev.vk.com/method/messages.edit Real fields: long, conversation_message_id, message, keyboard, peer_id, attachment, lat, group_id, keep_forward_messages, disable_mentions, keep_snippets, message_id, template, dont_parse_links Actual fields: long, conversation_message_id, message, keyboard, peer_id, attachment, lat, group_id, keep_forward_messages, keep_snippets, message_id, template, dont_parse_links +disable_mentions

  • ### messages.getChatPreview
    Link: https://dev.vk.com/method/messages.getChatPreview Real fields: fields, peer_id, link Actual fields: fields, link +peer_id

  • ### messages.getHistoryAttachments
    Link: https://dev.vk.com/method/messages.getHistoryAttachments Real fields: fields, start_from, photo_sizes, count, peer_id, media_type, group_id, max_forwards_level, preserve_order Actual fields: fields, start_from, photo_sizes, count, peer_id, media_type, group_id +preserve_order +max_forwards_level

  • ### messages.getInviteLink
    Link: https://dev.vk.com/method/messages.getInviteLink Real fields: group_id, peer_id, reset Actual fields: peer_id, reset +group_id

  • ### messages.getLongPollHistory
    Link: https://dev.vk.com/method/messages.getLongPollHistory Real fields: fields, msgs_limit, preview_length, pts, group_id, max_msg_id, lp_version, last_n, onlines, ts, credentials, events_limit Actual fields: fields, msgs_limit, preview_length, pts, group_id, max_msg_id, lp_version, onlines, ts, events_limit +credentials +last_n

  • ### messages.markAsRead
    Link: https://dev.vk.com/method/messages.markAsRead Real fields: peer_id, mark_conversation_as_read, group_id, start_message_id, message_ids Actual fields: mark_conversation_as_read, group_id, peer_id, start_message_id +message_ids

  • ### messages.send
    Link: https://dev.vk.com/method/messages.send Real fields: long, random_id, intent, peer_id, user_ids, payload, chat_id, subscribe_id, reply_to, forward, message, keyboard, user_id, attachment, disable_mentions, forward_messages, content_source, peer_ids, lat, group_id, template, sticker_id, domain, dont_parse_links Actual fields: long, title, random_id, intent, user_ids, peer_id, payload, chat_id, subscribe_id, reply_to, forward, message, keyboard, user_id, attachment, disable_mentions, forward_messages, content_source, lat, group_id, template, sticker_id, domain, dont_parse_links +peer_ids -title

  • ### messages.send
    Link: https://dev.vk.com/method/messages.send Real fields: long, random_id, intent, peer_id, user_ids, payload, chat_id, subscribe_id, reply_to, forward, message, keyboard, user_id, attachment, disable_mentions, forward_messages, content_source, peer_ids, lat, group_id, template, sticker_id, domain, dont_parse_links Actual fields: long, title, random_id, intent, user_ids, peer_id, payload, chat_id, subscribe_id, reply_to, forward, message, keyboard, user_id, attachment, disable_mentions, forward_messages, content_source, lat, group_id, template, sticker_id, domain, dont_parse_links +peer_ids -title

  • ### messages.setActivity
    Link: https://dev.vk.com/method/messages.setActivity Real fields: group_id, user_id, peer_id, type Actual fields: group_id, peer_id, type, used_id +user_id -used_id (typo)

  • ### newsfeed.getBanned
    Link: https://dev.vk.com/method/newsfeed.getBanned Real fields: extended, name_case, fields Actual fields: +extended +name_case +fields

  • ### newsfeed.unignoreItem
    Link: https://dev.vk.com/method/newsfeed.unignoreItem Real fields: type, track_code, item_id, owner_id Actual fields: type, item_id, owner_id +track_code

  • ### orders.getById
    Link: https://dev.vk.com/method/orders.getById Real fields: test_mode, order_ids, order_id Actual fields: test_mode, order_ids +order_id

  • ### photos.edit
    Link: https://dev.vk.com/method/photos.edit Real fields: latitude, foursquare_id, longitude, caption, place_str, delete_place, owner_id, photo_id Actual fields: captcha_key, latitude, captcha_sid, foursquare_id, longitude, caption, place_str, delete_place, owner_id, photo_id -captcha_sid -captcha_key

  • ### photos.getMessagesUploadServer
    Link: https://dev.vk.com/method/photos.getMessagesUploadServer Real fields: peer_id Actual fields: group_id +peer_id -group_id

  • ### photos.saveWallPhoto
    Link: https://dev.vk.com/method/photos.saveWallPhoto Real fields: latitude, hash, group_id, photo, longitude, caption, server, user_id Actual fields: hash, group_id, photo, caption, server, user_id +latitude +longitude

  • ### polls.addVote
    Link: https://dev.vk.com/method/polls.addVote Real fields: answer_ids, is_board, poll_id, owner_id Actual fields: is_board, poll_id, answer_id, owner_id +answer_ids -answer_id

  • ### polls.create
    Link: https://dev.vk.com/method/polls.create Real fields: question, disable_unvote, end_date, is_anonymous, owner_id, is_multiple, app_id, add_answers, photo_id, background_id Actual fields: question, end_date, is_anonymous, owner_id, is_multiple, background_id, add_answers, photo_id +app_id +disable_unvote

  • ### polls.edit
    Link: https://dev.vk.com/method/polls.edit Real fields: question, delete_answers, edit_answers, end_date, photo_id, owner_id, background_id, add_answers, poll_id Actual fields: question, delete_answers, edit_answers, owner_id, add_answers, poll_id +background_id +photo_id +end_date

  • ### polls.getById
    Link: https://dev.vk.com/method/polls.getById Real fields: fields, friends_count, name_case, extended, owner_id, is_board, poll_id Actual fields: is_board, poll_id, owner_id +fields +friends_count +extended +name_case

  • ### prettyCards.create
    Link: https://dev.vk.com/method/prettyCards.create Real fields: price, title, link, photo, price_old, button, owner_id Actual fields: price, title, photo, price_old, owner_id, is_board, poll_id +button +link -is_board -poll_id

  • ### prettyCards.edit
    Link: https://dev.vk.com/method/prettyCards.edit Real fields: price, title, link, photo, price_old, button, card_id, owner_id Actual fields: card_id, owner_id +price +title +link +photo +price_old +button

  • ### secure.getTransactionsHistory
    Link: https://dev.vk.com/method/secure.getTransactionsHistory Real fields: uid_to, uid_from, type, limit, date_from, date_to (check website, no parameters) Actual fields: +uid_to +uid_from +type +limit +date_from +date_to

  • ### secure.sendNotification
    Link: https://dev.vk.com/method/secure.sendNotification Real fields: message, user_id, user_ids Actual fields: message, user_ids +user_id

  • ### stats.getPostReach
    Link: https://dev.vk.com/method/stats.getPostReach Real fields: post_ids, owner_id Actual fields: post_id, owner_id +post_ids -post_id

  • ### stats.trackVisitor
    Link: https://dev.vk.com/method/stats.trackVisitor Real fields: id (check website, no parameters) Actual fields: +id

  • ### storage.get
    Link: https://dev.vk.com/method/storage.get Real fields: key, keys, user_id Actual fields: keys, user_id, global +key -global

  • ### storage.getKeys
    Link: https://dev.vk.com/method/storage.getKeys Real fields: user_id, offset, count Actual fields: user_id, global, offset, count -global

  • ### storage.set
    Link: https://dev.vk.com/method/storage.set Real fields: key, user_id, value Actual fields: global, key, user_id, value -global

  • ### stories.delete
    Link: https://dev.vk.com/method/stories.delete Real fields: story_id, stories, owner_id Actual fields: story_id, owner_id +stories

  • ### stories.get
    Link: https://dev.vk.com/method/stories.get Real fields: extended, fields, owner_id Actual fields: extended, owner_id +fields

  • ### stories.hideAllReplies
    Link: https://dev.vk.com/method/stories.hideAllReplies Real fields: group_id, owner_id Actual fields: owner_id +group_id

  • ### stories.hideReply
    Link: https://dev.vk.com/method/stories.hideReply Real fields: story_id, owner_id Actual fields: access_key, story_id, owner_id -access_key

  • ### users.search
    Link: https://dev.vk.com/method/users.search Real fields: hometown, university_faculty, position, company, sort, birth_month, q, offset, school_year, school, age_to, online, school_class, religion, from_list, university, city, university_country, has_photo, school_country, university_chair, birth_year, country, status, university_year, sex, fields, count, school_city, age_from, group_id, birth_day Actual fields: hometown, university_faculty, position, company, sort, birth_month, q, offset, school_year, interests, school, age_to, online, school_class, religion, from_list, university, city, university_country, has_photo, school_country, university_chair, birth_year, country, status, university_year, sex, fields, count, school_city, age_from, group_id, birth_day -interests

  • ### utils.getLinkStats
    Link: https://dev.vk.com/method/utils.getLinkStats Real fields: source, interval, intervals_count, extended, key, access_key Actual fields: interval, intervals_count, extended, key, access_key +source

  • ### video.get
    Link: https://dev.vk.com/method/video.get Real fields: fields, videos, count, extended, owner_id, album_id, offset Actual fields: videos, count, extended, owner_id, album_id, offset +fields

  • ### video.save
    Link: https://dev.vk.com/method/video.save Real fields: no_comments, name, repeat, link, is_private, group_id, compression, privacy_view, wallpost, privacy_comment, album_id, description Actual fields: no_comments, name, repeat, link, is_private, group_id, privacy_view, wallpost, privacy_comment, album_id, description +compression

  • ### video.search
    Link: https://dev.vk.com/method/video.search Real fields: longer, shorter, live, adult, filters, count, extended, sort, hd, q, search_own, offset Actual fields: longer, shorter, adult, filters, count, extended, sort, hd, q, search_own, offset +live

  • ### wall.edit
    Link: https://dev.vk.com/method/wall.edit Real fields: long, close_comments, post_id, place_id, poster_bkg_access_hash, owner_id, topic_id, copyright, friends_only, attachments, message, services, poster_bkg_id, poster_bkg_owner_id, mark_as_ads, donut_paid_duration, signed, lat, publish_date Actual fields: poster_bkg_id, long, mark_as_ads, attachments, message, post_id, services, close_comments, place_id, signed, lat, poster_bkg_access_hash, copyright, owner_id, friends_only, publish_date, poster_bkg_owner_id +donut_paid_duration +topic_id

  • ### wall.post
    Link: https://dev.vk.com/method/wall.post Real fields: long, close_comments, guid, post_id, place_id, owner_id, topic_id, copyright, friends_only, attachments, message, services, mute_notifications, from_group, mark_as_ads, donut_paid_duration, signed, lat, publish_date Actual fields: long, mark_as_ads, attachments, message, services, post_id, guid, place_id, owner_id, signed, lat, close_comments, mute_notifications, copyright, from_group, friends_only, publish_date +donut_paid_duration +topic_id (be careful, this parameter doesn't exist on the website)

  • ### wall.repost
    Link: https://dev.vk.com/method/wall.repost Real fields: mark_as_ads, message, mute_notifications, group_id, object Actual fields: group_id, message, object, mark_as_ads +mute_notifications

  • ### wall.repost
    Link: https://dev.vk.com/method/wall.repost Real fields: mark_as_ads, message, mute_notifications, group_id, object Actual fields: captcha_key, mark_as_ads, captcha_sid, message, group_id, object +mute_notifications -captcha_sid -captcha_key

Some methods that wasn't implemented in this library:

  • 1. adsweb.getAdCategories
  • 2. adsweb.getAdUnitCode
  • 3. adsweb.getAdUnits
  • 4. adsweb.getFraudHistory
  • 5. adsweb.getSites
  • 6. adsweb.getStatistics
  • 7. groups.ban
  • 8. market.editOrder
  • 9. market.getGroupOrders
  • 10. market.getOrderById
  • 11. market.getOrderItems
  • 12. market.getOrders
  • 13. market.searchItems
  • 14. store.addStickersToFavorite
  • 15. store.getFavoriteStickers
  • 16. store.getProducts
  • 17. store.getStickersKeywords
  • 18. store.removeStickersFromFavorite

I

@inyutin-maxim
Copy link
Member

Hi, @ablearthy I do not currently have time to support the project, but we are happy to accept PR. If you need to use an API that is incomplete or missing from the library, you can use the Call <T> https://github.com/vknet/vk/blob/develop/VkNet/VkApi.cs#L287

@inyutin-maxim inyutin-maxim added this to the v1.71.0 milestone Aug 18, 2022
@inyutin-maxim inyutin-maxim modified the milestones: v1.71.0, v1.72.0 Sep 3, 2022
@inyutin-maxim inyutin-maxim modified the milestones: v1.72.0, v1.73.0 Oct 19, 2022
@inyutin-maxim inyutin-maxim modified the milestones: v1.73.0, v1.74.0 Apr 9, 2023
@inyutin-maxim inyutin-maxim modified the milestones: v1.74.0, v1.75.0 May 3, 2023
@inyutin-maxim inyutin-maxim modified the milestones: v1.75.0, v1.76.0 Jul 10, 2023
@Panuchi Panuchi added the Задача Задача требующая реализации нового или доработке существующего функционала label Jul 19, 2023
Rahovski added a commit to Rahovski/vk that referenced this issue Aug 11, 2023
vknet#1222

- Add "PodcastSearchInfo" model for new answer from API method "podcasts.searchPodcast"
- Changed tests in "SearchPodcastTest" for new model
inyutin-maxim added a commit that referenced this issue Aug 13, 2023
## List of changes
- added support for method podcast.searchPodcast from list of methods in
issue: #1222
- old podcast methods marked as *Deprecated* ( **Warning**: vk support
team said, that api for podcast is offline )
- added new model *VkNet/Model/Results/Podcasts/PodcastSearchInfo.cs*
and rebuilded model
*VkNet/Model/Results/Podcasts/PodcastsSearchResult.cs* for support new
format of answer from api method
- rebuilded test sources and test cases for 'podcast.searchPodcast'
method

[Source for
podcast.searchPodcast](https://dev.vk.com/ru/method/podcasts.searchPodcast)

## Additional info about podcast methods

![изображение](https://github.com/vknet/vk/assets/9554636/89360618-30ea-4d91-99f7-abdf50056d29)

---------

Co-authored-by: inyutin-maxim <inyutin_maxim@mail.ru>
inyutin-maxim pushed a commit that referenced this issue Aug 14, 2023
Bound issue: #1222 

- Removed field *Tags* from args of method
- Added fields *Status* and *NeedVariants*
- Added unit test for method *market.search*

[Source of args](https://dev.vk.com/ru/method/market.search)
inyutin-maxim pushed a commit that referenced this issue Aug 28, 2023
## List of changes
- added field *is_hidden* to args of method

### Warning
Cannot add test data for this method, cause need to have market with
admin rights

### Sources

[Source of method](https://dev.vk.com/ru/method/market.editAlbum)

Bound with issue #1222
inyutin-maxim added a commit that referenced this issue Aug 28, 2023
## List of changes
- added support for new fields of method
*[market.get](https://dev.vk.com/ru/method/market.get)* - date_from,
date_to, need_variants, with_disabled
- added model *MarketGetParams* for wrap arguments for method
*market.get*
- added unit test and test data for thid method

[Source of args](https://dev.vk.com/ru/method/market.get)

Bound with issue #1222

---------

Co-authored-by: inyutin-maxim <inyutin_maxim@mail.ru>
@Rahovski
Copy link
Contributor

@inyutin-maxim
Please close this points
изображение

after #1581 and #1580

@Panuchi
Copy link
Contributor

Panuchi commented Sep 2, 2023

@inyutin-maxim

Please close this points

изображение

after #1581 and #1580

Готово

inyutin-maxim pushed a commit that referenced this issue Sep 11, 2023
## List of changes
- added field *is_hidden* to args of method

### Warning
Cannot add test data for this method, cause need to have market with
admin rights

### Sources

[Source of method](https://dev.vk.com/ru/method/market.addAlbum)

Bound with issue #1222
inyutin-maxim added a commit that referenced this issue Sep 11, 2023
## List of changes
- added fields *video_ids*, *variant_ids*, *is_main_variant* to
*MarketProductParams* model
- Rebuild order of argumets in method *edit* according api documentation

### Warning
Cannot add test data for this method, cause need to have market with
admin rights

### Sources

[Source of method](https://dev.vk.com/ru/method/market.edit)

Bound with issue #1222

Co-authored-by: inyutin-maxim <inyutin_maxim@mail.ru>
@inyutin-maxim inyutin-maxim modified the milestones: v1.76.0, v1.77.0 Sep 11, 2023
@Rahovski
Copy link
Contributor

@inyutin-maxim Please update issue, cause market.addalbum and market.edit was refresh by #1582 and #1584

@Panuchi
Copy link
Contributor

Panuchi commented Sep 12, 2023

@inyutin-maxim Please update issue, cause market.addalbum and market.edit was refresh by #1582 and #1584

Готово.

inyutin-maxim pushed a commit that referenced this issue Nov 11, 2023
## Список изменений
Исправлены warning
- Local constant 'expectedUserId' is never 
- Redundant 'Attribute' suffix
- Dictionary lookup can be simplified with 'TryGetValue'
- S6608: Indexing at 0 should be used instead of the "Enumerable"
extenion method "First"
- The keyword 'new' is required on 'AccessKey' because it hides property
'string VkNet.Model.MediaAttachment.AccessKey'
- Using directive is not required by the code and can be safely removed
- The keyword 'new' is required on 'PhotoId' because it hides property
'long? VkNet.Model.Comment.PhotoId'
- Conditional access qualifier expression is known to be not null
- Cannot resolve symbol BotsLongPollUpdatesHandler
- Code is unreachable

Обновил методы из #1222
- ads.getAds
- ads.getAdsLayout
- apps.get
- wall.postAdsStealth
- wall.editAdsStealth
- video.addToAlbum
- friends.areFriends
- friends.getMutual

##### Обязательно выполните следующие пункты:
- [x] Проверьте что ваш код не содержит конфликтов, и исправьте их по
необходимости
- [x] Напишите тесты, и обязательно проверьте что не падают другие.

##### Внимание! Pull Request'ы с непройденными тестами не принимаются
@inyutin-maxim inyutin-maxim modified the milestones: v1.77.0, v1.78.0 Nov 24, 2023
@inyutin-maxim inyutin-maxim modified the milestones: v1.78.0, v1.79.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Задача Задача требующая реализации нового или доработке существующего функционала
Projects
None yet
4 participants