added rank() method

[jakrin]

Vova, hi! I added rank() method and tests for it.

[vkostyukov]

Hi! This is an awsome contribution! Thank you. Please follow my comments. You can just commit to your la4j fork. All changes will be avaliable here.

[vkostyukov]

I guess we can use direct call get()/set() instead of this field.

[jakrin]

should I use rows()/columns() methods instead of fields?

[vkostyukov]

No, no. Filelds are OK.

[vkostyukov]

Also, don't forget to add yourself to "Contributors" section in the header of AbstractMatrix and Matrix interface.

[vkostyukov]

My point is there are always should be a brackets arround of operators. For example:

if (condition1) {
    doOne();
} else if (condition2) {
    doTwo();
} else {
    doThree();
}

Another example:

Wrong statement:

if (option) break;

Correct statement:

if (option) {
    break;
}

[aash]

I see a lots of comments concerning coding style/standard. So I would like to see coding standard for such a project, especially since this is common practice for any project where collaboration take place. Can I try to drop a draft of this document? If you agree, could you please create a ticket?
-- Thank you,
Alexey.

[vkostyukov]

Sure!

The common practice for Java developers is to use Java Code Convention document written in 1997. I gues 99% of all Java projects uses this code conventions.

[aash]

Since there's already industry wide standard for code style, there's no need to invent a bicycle. May be just put a link on front page? For example Apache made it different, they are using Oracle Java Coding Standard with several exceptions.

[vkostyukov]

Good point. I wiil put this information into README.md file.

[vkostyukov]

Thank you, @jakrin! You've done an awesome job!