Fix opencv-python version, with conditional formatting to point python 2.7 to the last supported version #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep python 2.7 support
…ep python 2.7 support
|
Thanks |
rar8000
pushed a commit
to rar8000/bCNC
that referenced
this pull request
Jul 21, 2023
Fix opencv-python version, with conditional formatting to point python 2.7 to the last supported version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting both python 2.7 and version 3 is hard when the opencv module dropped python 2 support.
Commits like:
lgv2018@fef4448 trying to fix #1468
fixed python 2 support, but broke python 3 support as mentioned in #1417 .
Some (LTS) distro's still defaults to python 2. @Harvie wanted to keep support for python 2.
To keep supporting both python versions conditional formatting is needed.
Python 2.7 will be pointed to the last supported openCV version. (4.2.0.32)
Python 3 will be pointed to install the recent opencv version.
Implements some of the code as discussed in pull request #1454
thanks to @GitHubCaps