Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended dark mode and light/dark toggle support #242

Closed
vladimiry opened this issue Jan 29, 2020 · 1 comment
Closed

Extended dark mode and light/dark toggle support #242

vladimiry opened this issue Jan 29, 2020 · 1 comment
Labels
enhancement planned

Comments

@vladimiry
Copy link
Owner

Since the app already uses Electron v7 we could utilize the goodies provided by https://www.electronjs.org/docs/api/native-theme API (available since v7).
@vladimiry vladimiry mentioned this issue Jan 29, 2020
Closed
@vladimiry vladimiry changed the title Extended dark mode support and light/dark toggle Extended dark mode support and enable light/dark toggle Jan 29, 2020
@vladimiry vladimiry changed the title Extended dark mode support and enable light/dark toggle Extended dark mode and light/dark toggle support Jan 30, 2020
@vladimiry vladimiry mentioned this issue Feb 1, 2021
Closed
@vladimiry vladimiry mentioned this issue Mar 22, 2021
Closed
@vladimiry
Copy link
Owner Author

vladimiry commented Apr 6, 2021 •
edited
Loading

Here is how it's going to look. The default value is "follow system" which means following the system preference.

Only the app UI gets affected. Maybe in new releases the app will apply the mode to @ProtonMail UI too (only applying on the fly without modifying the account dark/light mode preferences).

img

vladimiry added a commit that referenced this issue Apr 6, 2021
@vladimiry
enable support for dark/light mode, closes #242
b203fa4 
* Defaults to OS's dark mode preference.
vladimiry added a commit that referenced this issue Apr 7, 2021
@vladimiry
enable support for dark/light mode, closes #242
eec7593 
* Defaults to OS's dark mode preference.
vladimiry added a commit that referenced this issue Apr 8, 2021
@vladimiry
enable support for dark/light mode, closes #242
c96769a 
* Defaults to OS's dark mode preference.
vladimiry added a commit that referenced this issue Apr 8, 2021
@vladimiry
enable support for dark/light mode, closes #242
d9605a4 
* Defaults to OS's dark mode preference.
vladimiry added a commit that referenced this issue Apr 10, 2021
@vladimiry
fix font color of account activating timed/click delay indication, #242
9a9ffa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vladimiry