Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell-checking - Automatic language switching + option to manually define languages for spell-checking #469

Closed
itisafrickinhighlander opened this issue Dec 2, 2021 · 2 comments
Closed

Spell-checking - Automatic language switching + option to manually define languages for spell-checking #469

itisafrickinhighlander opened this issue Dec 2, 2021 · 2 comments
Labels
backlog enhancement user-experience

Comments

@itisafrickinhighlander
Copy link

I write emails in multiple languages and I always use spell-checking, but because of a lack of automatic language switching something native to Chromium-based browsers, but I am not sure how and if it integrated in Electron. They even work in this magical way that they can do like multi-lingual spell-checking at once, e.g. I am writing in English, and I include a quote in French. In those browsers it would underline only a typo, regardless of language.
I have to always switch it manually via RMB > Languages, otherwise everything is underlined and it is little distracting. But then again, Mozilla has a ticket for this open for well over 21 years and still counting. We don't exist for them.

Also, it would be sweet to have a language setting in ElectronMail to be able to define languages to be used. Currently, in my instance of EM, I see four English locales (en_CA, en_LR, en_PH, en_US) and French and German (it looks like it is using languages defined in OS (Windows 10).

What I personally think would be the perfect solution is something like it is done in Chromium (screenshot took from Brave, however)

image

I am not sure if this is possible, viable or worth the time, but hopefully there will be others finding this useful.
@vladimiry
Copy link
Owner

Switching to Chromium-based spellchecker is going to happen one day (@electron supports it since v8). See #216 for details.

@vladimiry vladimiry mentioned this issue Dec 9, 2021
Closed
@vladimiry
Copy link
Owner

Switching to Chromium-based spellchecker is going to happen one day

It's coming in the next release. So things like using multiple languages will be possible.

vladimiry added a commit that referenced this issue Aug 3, 2022
@vladimiry
drop "spellchecker" module in favor of a native spellcheker, closes #469
4fb6869 


* A native spellchecker is not an ideal thing, but "spellcheker" is a worse choice.
* There was an option to replace "specllcheker" with "nodehun" but a choice was made towards simplifying the code base by dropping the custom spellcheck provider based on a native module.
* The side benefit is reduced "Windows" and "Snap" packages size those were coming with packaged "hunspell" dictionaries.
vladimiry added a commit that referenced this issue Aug 4, 2022
@vladimiry
drop "spellchecker" module in favor of a native spellcheker, closes #469
20743d7 


* A native spellchecker is not an ideal thing, but "spellcheker" is a worse choice.
* There was an option to replace "specllcheker" with "nodehun" but a choice was made towards simplifying the code base by dropping the custom spellcheck provider based on a native module.
* The side benefit is reduced "Windows" and "Snap" packages size those were coming with packaged "hunspell" dictionaries.
vladimiry added a commit that referenced this issue Aug 7, 2022
@vladimiry
drop "spellchecker" module in favor of a native spellcheker, closes #469
035bdac 


* A native spellchecker is not an ideal thing, but "spellcheker" is a worse choice.
* There was an option to replace "specllcheker" with "nodehun" but a choice was made towards simplifying the code base by dropping the custom spellcheck provider based on a native module.
* The side benefit is reduced "Windows" and "Snap" packages size those were coming with packaged "hunspell" dictionaries.
vladimiry added a commit that referenced this issue Aug 11, 2022
@vladimiry
drop "spellchecker" module in favor of a native spellcheker, closes #469
03fbe61 


* A native spellchecker is not an ideal thing, but "spellcheker" is a worse choice.
* There was an option to replace "specllcheker" with "nodehun" but a choice was made towards simplifying the code base by dropping the custom spellcheck provider based on a native module.
* The side benefit is reduced "Windows" and "Snap" packages size those were coming with packaged "hunspell" dictionaries.
vladimiry added a commit to flathub/com.github.vladimiry.ElectronMail that referenced this issue Aug 27, 2022
@vladimiry
pre-update to v5.1.0
bf7f5be 
* Hunspell dicts no longer needed as 5.1.0 switches to a native/@electron/@chromium built-in spell checking, see vladimiry/ElectronMail#469 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement user-experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladimiry @itisafrickinhighlander