Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam and unread notification (count) #86

Closed
joshirio opened this issue Dec 25, 2018 · 7 comments
Closed

Spam and unread notification (count) #86

joshirio opened this issue Dec 25, 2018 · 7 comments

Comments

@joshirio
Copy link
Contributor

Since version 2.0.0 the app shows notifications and unread count indicator on spam folder but only if the local storage feature is enabled. I think it would make sense to preserve the feature as it was previously, meaning no notifications and unread status indicator for spam emails.

Is this intentional or a by product of the local email view that just checks for all folders?
I have an account which is getting spam mails all the time and would like, if possible, to be notified only for real emails.

@vladimiry
Copy link
Owner

This is the result of this feature enabing in along with enabling local store option.

So in the case of local store enabling unread counters will be derived from the entire local store instead of listening for Protonmail itself calls /api/messages/count API and picking the unread values from there.

Certainly spam folders can be omitted during local store scanning.

@joshirio
Copy link
Contributor Author

joshirio commented Dec 25, 2018

Certainly spam folders can be omitted during local store scanning.

that would be great, thanks

@vladimiry
Copy link
Owner

The pre v2.1.0 version is uploaded here. Does it work as expected?

In database mode spam emails are still shown as unread since I really prefer database mode shows a complete picture.

@joshirio
Copy link
Contributor Author

joshirio commented Dec 28, 2018 via email

@vladimiry
Copy link
Owner

Closing as resolved. The feature will be a part of the next release.

@vladimiry
Copy link
Owner

I've got a request describing that in some cases getting notifications for spam folders can be useful. Will consider making disabling spam folders scanning configurable.

@vladimiry vladimiry reopened this Jan 9, 2019
@vladimiry
Copy link
Owner

Resolved with v2.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants