Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid warning from compiler with smart casting #19539

Closed
islonely opened this issue Oct 10, 2023 · 0 comments · Fixed by #19843
Closed

Invalid warning from compiler with smart casting #19539

islonely opened this issue Oct 10, 2023 · 0 comments · Fixed by #19843
Labels
Bug This tag is applied to issues which reports bugs. Unit: Checker Bugs/feature requests, that are related to the type checker.

Comments

@islonely
Copy link
Contributor

islonely commented Oct 10, 2023

Describe the bug

Using a variable for if mut var is Type { ... } produces the unused variable V warning even though it is being used. if var is Type { ... } does not have the same warning. Ideally it should instead let me know to use the if statement without the mut in it.

Reproduction Steps

struct Foo {
	value int = 0xf00
}

struct Bar {}

type FooBar = Bar | Foo

fn main() {
	mut foobar := FooBar(Bar{})
	if mut foobar is Foo {
		println('foo')
	} else {
		println('bar')
	}
}

Expected Behavior

output:

bar

Current Behavior

output:

C:/Users/imado/Documents/test.v:10:6: warning: unused variable: `foobar`
    8 | 
    9 | fn main() {
   10 |     mut foobar := FooBar(Bar{})
      |         ~~~~~~
   11 |     if mut foobar is Foo {
   12 |         println('foo')
bar

Possible Solution

No response

Additional Information/Context

No response

V version

V 0.4.2 37e5616

Environment details (OS name and version, etc.)

V full version: V 0.4.2 37e5616
OS: windows, Microsoft Windows 11 Pro v22621 64-bit
Processor: 16 cpus, 64bit, little endian, 

getwd: C:\Users\imado\Documents\cyberian_tiger
vexe: C:\Users\imado\v\v.exe
vexe mtime: 2023-10-09 22:29:31

vroot: OK, value: C:\Users\imado\v
VMODULES: OK, value: C:\Users\imado\.vmodules
VTMP: OK, value: C:\Users\imado\AppData\Local\Temp\v_0

Git version: git version 2.33.1.windows.1
Git vroot status: weekly.2023.40.1-50-g37e5616b
.git/config present: true

CC version: Error: 'cc' is not recognized as an internal or external command,
operable program or batch file.

thirdparty/tcc status: thirdparty-windows-amd64 e90c2620

Note

You can vote for this issue using the 👍 reaction. More votes increase the issue's priority for developers.

Take into account that only the 👍 reaction counts as a vote.
Only reactions to the issue itself will be counted as votes, not comments.

@islonely islonely added the Bug This tag is applied to issues which reports bugs. label Oct 10, 2023
@ArtemkaKun ArtemkaKun added the Unit: Checker Bugs/feature requests, that are related to the type checker. label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Unit: Checker Bugs/feature requests, that are related to the type checker.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants