-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vlib: add toml module + tests #11964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larpon
commented
Sep 24, 2021
spytheman
reviewed
Sep 24, 2021
…py-paste method documentation
spytheman
reviewed
Sep 24, 2021
spytheman
reviewed
Sep 24, 2021
spytheman
reviewed
Sep 24, 2021
spytheman
reviewed
Sep 24, 2021
spytheman
reviewed
Sep 24, 2021
spytheman
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @larpon !
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V + TOML = ❤️
toml
module with ~99.9% TOML 1.0 format compatibility written in pure V.I'll work on ironing out more checker errors to make it pass all (or most) of the invalid test suite TOML docs from here https://github.com/BurntSushi/toml-test/). The parser currently pass almost all of the valid tests which is why I think it's a good time to contribute it to vlib. To check against the test suite I've added a small CI job to make sure we can catch regressions.
In the future it'd be nice to make the value retrieval tests pass by testing against the json files - but there's still a little way to go.
It can currently parse TOML files and retrieve values correctly, except for >2 level array-table-array constructs looking like this:
It can be fixed over time along with the rest of the test suite files.
Happy TOMLing 🙂