builder: fix compiling code, importing a module located in src/modules
#19396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
changed the title
src/modules
JalonSolov
reviewed
Sep 20, 2023
| v.module_search_paths << os.join_path(v.compiled_dir, 'modules') | ||
| if os.exists(os.join_path(v.compiled_dir, 'src/modules')) { | ||
| v.module_search_paths << os.join_path(v.compiled_dir, 'src/modules') | ||
| } else { |
There was a problem hiding this comment.
Maybe the contents of src/module will take precedence.
There was a problem hiding this comment.
If I put modules in both places, they should work in both places. The way your code is now, the ones in modules will be completely ignored if there is a src/modules. This would be bad if there are completely different modules in both directories.
There was a problem hiding this comment.
I have created a pull request to resolve this issue. #19437
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem where modules in src were not recognized.