Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: unwrap generics for map and array methods #20059

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Dec 1, 2023

Fixes #20058

🤖[deprecated] Generated by Copilot at ff7a29d

This pull request fixes a bug with calling methods on generic types in the checker module. It also adds a test case in generic_fn_call_map_keys_values_test.v to verify the fix.

🤖[deprecated] Generated by Copilot at ff7a29d

  • Fix bug where calling map methods on generic types would not work properly (link, link)
  • Add test case for the bug fix in vlib/v/tests/generic_fn_call_map_keys_values_test.v (link)

@Delta456 Delta456 marked this pull request as draft December 1, 2023 20:03
@Delta456 Delta456 marked this pull request as ready for review December 4, 2023 16:46
@Delta456
Copy link
Member Author

Delta456 commented Dec 4, 2023

I would like to thank @shove70 for helping me to fix the test!

@spytheman spytheman merged commit cce21a4 into vlang:master Dec 4, 2023
53 of 54 checks passed
@Delta456 Delta456 deleted the checker_unwrap_map_array branch December 4, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler panic when calling map.keys() or map.values() in a generic function
2 participants