Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix spawn when calling undefined function #21906

Merged
merged 3 commits into from
Jul 23, 2024
Merged

checker: fix spawn when calling undefined function #21906

merged 3 commits into from
Jul 23, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Jul 21, 2024 •
edited
Loading

Fix #21905

This PR makes undefined function error as fatal.

@spytheman
Copy link
Member

Something like this seems to work, without using c.fatal:
image

@felipensp
Copy link
Member Author

Something like this seems to work, without using c.fatal: image

Yes, I also thought that. But as imho it is not too obvious check I came to a fatal one. But I'm ok with your suggestion.

@felipensp felipensp marked this pull request as ready for review July 22, 2024 14:09
@spytheman spytheman merged commit 6e8124f into vlang:master Jul 23, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug while practicing copying the concurrency examples
2 participants
@felipensp @spytheman