Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmpl: add escape for @ using @@ #22303

Merged
merged 2 commits into from
Sep 25, 2024
Merged

tmpl: add escape for @ using @@ #22303

merged 2 commits into from
Sep 25, 2024

Conversation

felipensp
Copy link
Member

Fix #22299

@spytheman spytheman marked this pull request as ready for review September 25, 2024 06:24
spytheman
spytheman approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, especially the test, so that it will not regress silently anymore, like it did already before.

The CI failure is unrelated and fixed on master.

@spytheman spytheman merged commit 1a4ad55 into vlang:master Sep 25, 2024
77 of 78 checks passed
@felipensp felipensp deleted the fix_tmpl_escape_at branch September 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JalonSolov JalonSolov JalonSolov left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Templates don't accept @@ anymore
3 participants
@felipensp @spytheman @JalonSolov