checker, cgen: fix comptime issues with generic type #22751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Nov 5, 2024
spytheman
reviewed
Nov 5, 2024
spytheman
reviewed
Nov 5, 2024
| @@ -53,6 +53,7 @@ fn (mut g Gen) struct_init(node ast.StructInit) { | |||
| if mut sym.info is ast.Struct { | |||
| is_anon = sym.info.is_anon | |||
| } | |||
| is_generic_default := sym.kind !in [.struct, .array_fixed] && node.typ.has_flag(.generic) // T{} | |||
There was a problem hiding this comment.
I do not understand, how is not being a struct or fixed array related to a property named is_generic_default?
There was a problem hiding this comment.
Can you add a small comment here, mentioning var := X{} , for X being map[K]T or []T ?
spytheman
reviewed
Nov 5, 2024
spytheman
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22710
Fix #22642
This PR fixes issues like:
With default type codegen:
where
Tis a non-struct type (e.g.map[K]Tor[]T).mut variables assignment from generic fn return
selector expr with
.stron generic typeAnd possible regeneration of already generated closure.
rename
g.comptime.get_comptime_var_typetog.comptime.get_type.Huly®: V_0.6-21197