Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v: reduce table.sym() consecutive calls by using new table.sym2() #22882

Closed
wants to merge 2 commits into from

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 16, 2024

This PR aims reduce consecutive calls to table.sym().

image

image

image

Huly®: V_0.6-21325

@felipensp felipensp changed the title v: reduce table.sym() called consecutively by using new table.sym2() v: reduce table.sym() consecutive calls by using new table.sym2() Nov 16, 2024
@felipensp felipensp marked this pull request as ready for review November 16, 2024 23:52
@spytheman
Copy link
Member

On my Linux machine, it was not very conclusive (in most cases the PR version was slower than master, but not by very much):

#0 09:15:40 ^ opt_sym2 ~/code/v>v run .github/workflows/compare_pr_to_master.v 
==================================================================================================
Current git branch: opt_sym2, commit: 01daf62
    Compiling new V executables from PR branch: opt_sym2, commit: 01daf62 ...
CPU: 2.41s      Real: 2.66s     Elapsed: 0:02.66        RAM: 404344KB   ./v -o vnew1 cmd/v
CPU: 2.41s      Real: 2.66s     Elapsed: 0:02.66        RAM: 404396KB   ./vnew1 -o vnew2 cmd/v
CPU: 2.42s      Real: 2.64s     Elapsed: 0:02.64        RAM: 388648KB   ./vnew2 -no-parallel -o vnew cmd/v
CPU: 0.20s      Real: 0.22s     Elapsed: 0:00.22        RAM: 47448KB    ./vnew -no-parallel -o nhw_current.c examples/hello_world.v
CPU: 1.97s      Real: 2.20s     Elapsed: 0:02.20        RAM: 388724KB   ./vnew -no-parallel -o nv_current.c cmd/v
>Size of        nhw_current.c:     460077
>Size of         nv_current.c:    6863765
>Size of                 vnew:   10459216
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
==================================================================================================
    Compiling old V executables from branch: master, commit: e234a2d ...
CPU: 2.43s      Real: 2.65s     Elapsed: 0:02.65        RAM: 404340KB   ./v -o vold1 cmd/v
CPU: 2.44s      Real: 2.65s     Elapsed: 0:02.65        RAM: 404408KB   ./vold1 -o vold2 cmd/v
CPU: 2.39s      Real: 2.63s     Elapsed: 0:02.63        RAM: 388720KB   ./vold2 -no-parallel -o vold cmd/v
CPU: 0.19s      Real: 0.22s     Elapsed: 0:00.22        RAM: 47436KB    ./vold -no-parallel -o ohw_master.c examples/hello_world.v
CPU: 2.00s      Real: 2.20s     Elapsed: 0:02.20        RAM: 388708KB   ./vold -no-parallel -o ov_master.c cmd/v
>Size of         ohw_master.c:     460077
>Size of          ov_master.c:    6858767
>Size of                 vold:   10455528
==================================================================================================
File sizes so far ...
>>>>>> size("  nhw_current.c") - size("   ohw_master.c") =     460077 -     460077 =          0
>>>>>> size("   nv_current.c") - size("    ov_master.c") =    6863765 -    6858767 =       4998
>>>>>> size("           vnew") - size("           vold") =   10459216 -   10455528 =       3688
Switched to branch 'opt_sym2'
==================================================================================================
    Measuring at PR branch: opt_sym2, commit: 01daf62 ...
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1                                                                                  
 >  1         base         112.3ms ± σ:   0.2ms, 112.1ms…112.5ms `./vold -check-syntax           examples/hello_world.v`
    2   +0.6% 1.01x slower 113.0ms ± σ:   0.4ms, 112.4ms…113.3ms `./vnew -check-syntax           examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2                                                                                  
 >  1         base         112.2ms ± σ:   0.1ms, 112.0ms…112.3ms `./vold -check-syntax           examples/hello_world.v`
    2   +0.3% 1.00x slower 112.6ms ± σ:   0.1ms, 112.4ms…112.6ms `./vnew -check-syntax           examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3                                                                                  
 >  1         base         112.3ms ± σ:   0.1ms, 112.1ms…112.4ms `./vold -check-syntax           examples/hello_world.v`
    2   +0.2% 1.00x slower 112.5ms ± σ:   0.2ms, 112.2ms…112.7ms `./vnew -check-syntax           examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1                                                                                  
 >  1         base         164.1ms ± σ:   0.1ms, 164.0ms…164.2ms `./vold -check                  examples/hello_world.v`
    2   +0.6% 1.01x slower 165.1ms ± σ:   0.2ms, 164.9ms…165.2ms `./vnew -check                  examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2                                                                                  
 >  1         base         164.0ms ± σ:   0.0ms, 163.9ms…164.0ms `./vold -check                  examples/hello_world.v`
    2   +0.6% 1.01x slower 165.0ms ± σ:   0.1ms, 164.9ms…165.1ms `./vnew -check                  examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3                                                                                  
 >  1         base         164.0ms ± σ:   0.1ms, 164.0ms…164.1ms `./vold -check                  examples/hello_world.v`
    2   +0.6% 1.01x slower 165.0ms ± σ:   0.1ms, 164.9ms…165.1ms `./vnew -check                  examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1                                                                                  
 >  1         base         223.5ms ± σ:   0.1ms, 223.3ms…223.5ms `./vold -no-parallel -o ohw.c   examples/hello_world.v`
    2   +0.7% 1.01x slower 225.0ms ± σ:   0.0ms, 225.0ms…225.0ms `./vnew -no-parallel -o nhw.c   examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2                                                                                  
 >  1         base         223.5ms ± σ:   0.1ms, 223.4ms…223.5ms `./vold -no-parallel -o ohw.c   examples/hello_world.v`
    2   +0.7% 1.01x slower 225.1ms ± σ:   0.2ms, 225.0ms…225.4ms `./vnew -no-parallel -o nhw.c   examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3                                                                                  
 >  1         base         223.3ms ± σ:   0.1ms, 223.2ms…223.4ms `./vold -no-parallel -o ohw.c   examples/hello_world.v`
    2   +0.8% 1.01x slower 225.2ms ± σ:   0.1ms, 225.0ms…225.2ms `./vnew -no-parallel -o nhw.c   examples/hello_world.v`
>>>>>> size("          nhw.c") - size("          ohw.c") =     460077 -     460077 =          0
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1                                                                                  
 >  1         base         252.1ms ± σ:   0.2ms, 251.8ms…252.3ms `./vold -no-parallel -o ohw.exe examples/hello_world.v`
    2   +0.7% 1.01x slower 253.7ms ± σ:   0.1ms, 253.6ms…253.8ms `./vnew -no-parallel -o nhw.exe examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2                                                                                  
 >  1         base         252.3ms ± σ:   0.2ms, 252.1ms…252.6ms `./vold -no-parallel -o ohw.exe examples/hello_world.v`
    2   +0.5% 1.00x slower 253.5ms ± σ:   0.3ms, 253.2ms…253.8ms `./vnew -no-parallel -o nhw.exe examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3                                                                                  
 >  1         base         252.2ms ± σ:   0.2ms, 251.9ms…252.4ms `./vold -no-parallel -o ohw.exe examples/hello_world.v`
    2   +0.7% 1.01x slower 254.0ms ± σ:   0.1ms, 253.8ms…254.2ms `./vnew -no-parallel -o nhw.exe examples/hello_world.v`
>>>>>> size("        nhw.exe") - size("        ohw.exe") =     726224 -     726224 =          0
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1                                                                                  
    1   -0.3% 1.00x faster 916.7ms ± σ:   0.7ms, 916.0ms…917.6ms `./vnew -check-syntax           cmd/v`
 >  2         base         919.5ms ± σ:   0.4ms, 919.0ms…919.9ms `./vold -check-syntax           cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2                                                                                  
    1   -0.3% 1.00x faster 916.7ms ± σ:   0.2ms, 916.5ms…916.9ms `./vnew -check-syntax           cmd/v`
 >  2         base         919.1ms ± σ:   0.1ms, 918.9ms…919.3ms `./vold -check-syntax           cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
    1   -0.3% 1.00x faster 916.3ms ± σ:   0.1ms, 916.1ms…916.5ms `./vnew -check-syntax           cmd/v`
 >  2         base         919.1ms ± σ:   0.2ms, 918.8ms…919.3ms `./vold -check-syntax           cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base         1506.5ms ± σ:   0.4ms, 1506.0ms…1507.1ms `./vold -check                  cmd/v`
    2   +0.2% 1.00x slower 1509.6ms ± σ:   0.0ms, 1509.6ms…1509.7ms `./vnew -check                  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base         1506.6ms ± σ:   0.4ms, 1506.2ms…1507.2ms `./vold -check                  cmd/v`
    2   +0.2% 1.00x slower 1510.0ms ± σ:   0.2ms, 1509.7ms…1510.2ms `./vnew -check                  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
 >  1         base         1506.4ms ± σ:   0.8ms, 1505.3ms…1507.1ms `./vold -check                  cmd/v`
    2   +0.2% 1.00x slower 1508.9ms ± σ:   0.2ms, 1508.7ms…1509.1ms `./vnew -check                  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base         2198.7ms ± σ:   0.5ms, 2198.2ms…2199.4ms `./vold -no-parallel -o ov.c    cmd/v`
    2   +0.4% 1.00x slower 2208.0ms ± σ:   0.5ms, 2207.7ms…2208.7ms `./vnew -no-parallel -o nv.c    cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base         2198.9ms ± σ:   0.2ms, 2198.6ms…2199.3ms `./vold -no-parallel -o ov.c    cmd/v`
    2   +0.4% 1.00x slower 2208.4ms ± σ:   1.0ms, 2207.5ms…2209.8ms `./vnew -no-parallel -o nv.c    cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
 >  1         base         2201.4ms ± σ:   0.3ms, 2201.0ms…2201.8ms `./vold -no-parallel -o ov.c    cmd/v`
    2   +0.3% 1.00x slower 2207.9ms ± σ:   0.7ms, 2207.1ms…2208.7ms `./vnew -no-parallel -o nv.c    cmd/v`
>>>>>> size("           nv.c") - size("           ov.c") =    6863765 -    6863765 =          0
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base         2634.5ms ± σ:   0.2ms, 2634.2ms…2634.8ms `./vold -no-parallel -o ov.exe  cmd/v`
    2   +0.2% 1.00x slower 2639.9ms ± σ:   0.7ms, 2639.3ms…2640.9ms `./vnew -no-parallel -o nv.exe  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base         2632.9ms ± σ:   0.3ms, 2632.5ms…2633.3ms `./vold -no-parallel -o ov.exe  cmd/v`
    2   +0.3% 1.00x slower 2641.3ms ± σ:   1.1ms, 2639.9ms…2642.2ms `./vnew -no-parallel -o nv.exe  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
 >  1         base         2632.7ms ± σ:   0.8ms, 2631.5ms…2633.4ms `./vold -no-parallel -o ov.exe  cmd/v`
    2   +0.4% 1.00x slower 2642.4ms ± σ:   1.1ms, 2640.9ms…2643.2ms `./vnew -no-parallel -o nv.exe  cmd/v`
>>>>>> size("         nv.exe") - size("         ov.exe") =   10459240 -   10459240 =          0
Done. Total time: 600.035140648 s.
==================================================================================================
Final summary for file diff sizes on their own branches:
>>>>>> size("  nhw_current.c") - size("   ohw_master.c") =     460077 -     460077 =          0
>>>>>> size("   nv_current.c") - size("    ov_master.c") =    6863765 -    6858767 =       4998
>>>>>> size("           vnew") - size("           vold") =   10459216 -   10455528 =       3688
==================================================================================================
Final summary for file diff sizes for generated files on the *current* branch:
>>>>>> size("          nhw.c") - size("          ohw.c") =     460077 -     460077 =          0
>>>>>> size("           nv.c") - size("           ov.c") =    6863765 -    6863765 =          0
>>>>>> size("        nhw.exe") - size("        ohw.exe") =     726224 -     726224 =          0
>>>>>> size("         nv.exe") - size("         ov.exe") =   10459240 -   10459240 =          0
#0 09:25:46 ^ opt_sym2 ~/code/v>

@spytheman
Copy link
Member

The results on my m1 were also not conclusive:

0[09:06:10]@m1: (opt_sym2) /opt/v $ v run .github/workflows/compare_pr_to_master.v
==================================================================================================
Current git branch: opt_sym2, commit: 7e886f5
    Compiling new V executables from PR branch: opt_sym2, commit: 7e886f5 ...
CPU: 5.46s	Real: 5.29s	Elapsed: 0:05.29	RAM: 388544KB	./v -o vnew1 cmd/v
CPU: 4.97s	Real: 5.16s	Elapsed: 0:05.16	RAM: 387920KB	./vnew1 -o vnew2 cmd/v
CPU: 4.87s	Real: 5.36s	Elapsed: 0:05.36	RAM: 365456KB	./vnew2 -no-parallel -o vnew cmd/v
CPU: 0.10s	Real: 0.41s	Elapsed: 0:00.41	RAM: 41296KB	./vnew -no-parallel -o nhw_current.c examples/hello_world.v
CPU: 1.00s	Real: 1.14s	Elapsed: 0:01.14	RAM: 363552KB	./vnew -no-parallel -o nv_current.c cmd/v
>Size of        nhw_current.c:     460272
>Size of         nv_current.c:    6866160
>Size of                 vnew:    4247384
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
==================================================================================================
    Compiling old V executables from branch: master, commit: e234a2d ...
CPU: 5.43s	Real: 5.23s	Elapsed: 0:05.23	RAM: 390528KB	./v -o vold1 cmd/v
CPU: 4.96s	Real: 5.13s	Elapsed: 0:05.13	RAM: 388032KB	./vold1 -o vold2 cmd/v
CPU: 4.89s	Real: 5.39s	Elapsed: 0:05.39	RAM: 367984KB	./vold2 -no-parallel -o vold cmd/v
CPU: 0.11s	Real: 0.43s	Elapsed: 0:00.43	RAM: 40848KB	./vold -no-parallel -o ohw_master.c examples/hello_world.v
CPU: 1.00s	Real: 1.13s	Elapsed: 0:01.13	RAM: 364976KB	./vold -no-parallel -o ov_master.c cmd/v
>Size of         ohw_master.c:     460272
>Size of          ov_master.c:    6861162
>Size of                 vold:    4247336
==================================================================================================
File sizes so far ...
>>>>>> size("  nhw_current.c") - size("   ohw_master.c") =     460272 -     460272 =          0
>>>>>> size("   nv_current.c") - size("    ov_master.c") =    6866160 -    6861162 =       4998
>>>>>> size("           vnew") - size("           vold") =    4247384 -    4247336 =         48
Switched to branch 'opt_sym2'
==================================================================================================
    Measuring at PR branch: opt_sym2, commit: 7e886f5 ...
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
    1   -0.4% 1.00x faster  58.2ms ± σ:   0.2ms,  58.1ms… 58.5ms `./vnew -check-syntax           examples/hello_world.v`
 >  2         base          58.4ms ± σ:   0.2ms,  58.3ms… 58.7ms `./vold -check-syntax           examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
    1   -0.0% 1.00x ~same~  58.4ms ± σ:   0.2ms,  58.2ms… 58.5ms `./vnew -check-syntax           examples/hello_world.v`
 >  2         base          58.4ms ± σ:   0.1ms,  58.2ms… 58.5ms `./vold -check-syntax           examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
    1   -0.1% 1.00x ~same~  58.1ms ± σ:   0.1ms,  58.0ms… 58.2ms `./vnew -check-syntax           examples/hello_world.v`
 >  2         base          58.1ms ± σ:   0.0ms,  58.1ms… 58.2ms `./vold -check-syntax           examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base          82.9ms ± σ:   0.2ms,  82.7ms… 83.1ms `./vold -check                  examples/hello_world.v`
    2   +0.0% 1.00x ~same~  82.9ms ± σ:   0.1ms,  82.8ms… 83.1ms `./vnew -check                  examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base          82.8ms ± σ:   0.2ms,  82.5ms… 83.0ms `./vold -check                  examples/hello_world.v`
    2   +0.4% 1.00x slower  83.1ms ± σ:   0.1ms,  83.0ms… 83.3ms `./vnew -check                  examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
    1   -0.0% 1.00x ~same~  83.0ms ± σ:   0.1ms,  82.9ms… 83.2ms `./vnew -check                  examples/hello_world.v`
 >  2         base          83.0ms ± σ:   0.2ms,  82.8ms… 83.2ms `./vold -check                  examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
    1   -0.5% 1.00x faster 117.6ms ± σ:   0.4ms, 117.2ms…118.1ms `./vnew -no-parallel -o nhw.c   examples/hello_world.v`
 >  2         base         118.2ms ± σ:   0.5ms, 117.5ms…118.6ms `./vold -no-parallel -o ohw.c   examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base         117.3ms ± σ:   0.1ms, 117.2ms…117.4ms `./vold -no-parallel -o ohw.c   examples/hello_world.v`
    2   +0.9% 1.01x slower 118.4ms ± σ:   0.2ms, 118.3ms…118.6ms `./vnew -no-parallel -o nhw.c   examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
    1   -0.3% 1.00x faster 118.1ms ± σ:   0.1ms, 118.0ms…118.2ms `./vnew -no-parallel -o nhw.c   examples/hello_world.v`
 >  2         base         118.4ms ± σ:   0.1ms, 118.3ms…118.6ms `./vold -no-parallel -o ohw.c   examples/hello_world.v`
>>>>>> size("          nhw.c") - size("          ohw.c") =     460272 -     460272 =          0
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
    1   -0.3% 1.00x faster 418.0ms ± σ:   0.5ms, 417.7ms…418.7ms `./vnew -no-parallel -o nhw.exe examples/hello_world.v`
 >  2         base         419.4ms ± σ:   0.4ms, 419.0ms…419.9ms `./vold -no-parallel -o ohw.exe examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base         422.7ms ± σ:   1.0ms, 421.6ms…424.0ms `./vold -no-parallel -o ohw.exe examples/hello_world.v`
    2   +0.5% 1.01x slower 424.9ms ± σ:   0.5ms, 424.5ms…425.6ms `./vnew -no-parallel -o nhw.exe examples/hello_world.v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
    1   -0.2% 1.00x faster 424.0ms ± σ:   0.2ms, 423.7ms…424.2ms `./vnew -no-parallel -o nhw.exe examples/hello_world.v`
 >  2         base         424.7ms ± σ:   0.1ms, 424.6ms…424.8ms `./vold -no-parallel -o ohw.exe examples/hello_world.v`
>>>>>> size("        nhw.exe") - size("        ohw.exe") =     430056 -     430056 =          0
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base         436.0ms ± σ:   0.5ms, 435.3ms…436.4ms `./vold -check-syntax           cmd/v`
    2   +0.0% 1.00x ~same~ 436.2ms ± σ:   0.2ms, 436.0ms…436.4ms `./vnew -check-syntax           cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
    1   -0.1% 1.00x ~same~ 435.4ms ± σ:   0.4ms, 434.8ms…435.8ms `./vnew -check-syntax           cmd/v`
 >  2         base         435.7ms ± σ:   0.1ms, 435.6ms…435.8ms `./vold -check-syntax           cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
 >  1         base         431.5ms ± σ:   0.3ms, 431.1ms…431.7ms `./vold -check-syntax           cmd/v`
    2   +1.0% 1.01x slower 435.9ms ± σ:   0.3ms, 435.6ms…436.3ms `./vnew -check-syntax           cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base         711.5ms ± σ:   0.2ms, 711.2ms…711.7ms `./vold -check                  cmd/v`
    2   +0.1% 1.00x ~same~ 712.0ms ± σ:   0.6ms, 711.5ms…712.8ms `./vnew -check                  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
    1   -0.0% 1.00x ~same~ 711.0ms ± σ:   0.9ms, 710.0ms…712.3ms `./vnew -check                  cmd/v`
 >  2         base         711.2ms ± σ:   0.4ms, 710.7ms…711.7ms `./vold -check                  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
 >  1         base         710.7ms ± σ:   0.6ms, 710.3ms…711.6ms `./vold -check                  cmd/v`
    2   +0.2% 1.00x slower 711.9ms ± σ:   0.8ms, 710.9ms…712.8ms `./vnew -check                  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
    1   -0.4% 1.00x faster 1138.0ms ± σ:   0.9ms, 1136.7ms…1138.8ms `./vnew -no-parallel -o nv.c    cmd/v`
 >  2         base         1142.8ms ± σ:   2.1ms, 1140.1ms…1145.2ms `./vold -no-parallel -o ov.c    cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
 >  1         base         1135.6ms ± σ:   0.6ms, 1134.9ms…1136.5ms `./vold -no-parallel -o ov.c    cmd/v`
    2   +0.3% 1.00x slower 1139.1ms ± σ:   0.5ms, 1138.5ms…1139.7ms `./vnew -no-parallel -o nv.c    cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
 >  1         base         1136.8ms ± σ:   1.5ms, 1135.4ms…1138.9ms `./vold -no-parallel -o ov.c    cmd/v`
    2   +0.1% 1.00x ~same~ 1137.7ms ± σ:   1.1ms, 1136.2ms…1138.7ms `./vnew -no-parallel -o nv.c    cmd/v`
>>>>>> size("           nv.c") - size("           ov.c") =    6866160 -    6866160 =          0
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  1
 >  1         base         5010.3ms ± σ:  12.5ms, 4992.7ms…5019.5ms `./vold -no-parallel -o ov.exe  cmd/v`
    2   +0.2% 1.00x slower 5022.2ms ± σ:   6.2ms, 5013.7ms…5028.4ms `./vnew -no-parallel -o nv.exe  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  2
    1   -0.4% 1.00x faster 4995.1ms ± σ:  19.0ms, 4978.8ms…5021.8ms `./vnew -no-parallel -o nv.exe  cmd/v`
 >  2         base         5016.2ms ± σ:   6.7ms, 5007.0ms…5023.0ms `./vold -no-parallel -o ov.exe  cmd/v`
Summary after 1 series x 10 runs (%s are relative to first command, or `base`), discard maxs:  7, repeat:  3
    1   -0.2% 1.00x faster 5010.9ms ± σ:   4.8ms, 5004.2ms…5015.4ms `./vnew -no-parallel -o nv.exe  cmd/v`
 >  2         base         5020.4ms ± σ:   6.1ms, 5015.7ms…5029.0ms `./vold -no-parallel -o ov.exe  cmd/v`
>>>>>> size("         nv.exe") - size("         ov.exe") =    4247384 -    4247384 =          0
Done. Total time: 613.22817 s.
==================================================================================================
Final summary for file diff sizes on their own branches:
>>>>>> size("  nhw_current.c") - size("   ohw_master.c") =     460272 -     460272 =          0
>>>>>> size("   nv_current.c") - size("    ov_master.c") =    6866160 -    6861162 =       4998
>>>>>> size("           vnew") - size("           vold") =    4247384 -    4247336 =         48
==================================================================================================
Final summary for file diff sizes for generated files on the *current* branch:
>>>>>> size("          nhw.c") - size("          ohw.c") =     460272 -     460272 =          0
>>>>>> size("           nv.c") - size("           ov.c") =    6866160 -    6866160 =          0
>>>>>> size("        nhw.exe") - size("        ohw.exe") =     430056 -     430056 =          0
>>>>>> size("         nv.exe") - size("         ov.exe") =    4247384 -    4247384 =          0
0[09:16:27]@m1: (opt_sym2) /opt/v $

@spytheman
Copy link
Member

With -prod, it is a mixed bag on both linux and macos.

I do not think it is worth the increased complexity and code size.

@spytheman spytheman closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants