Migrate slots to U256 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aajj999
commented
Jun 6, 2024
aajj999
commented
- Migrate slot library to U256
- Use 256 in ERC721Token & ERC20Token
- Implement From and Into for U256 type (Bytes32)
- Add from_field function for U256
| } | ||
|
|
||
| bytes | ||
| } |
| let low = U128::from_le_bytes(low_bytes); | ||
|
|
||
| U256::new(high, low) | ||
| } |
ethereum/circuits/lib/src/uint256.nr
Outdated
|
|
||
| fn from_field(field: Field) -> Self { | ||
| U256::from_bytes32(field_to_bytes32(field)) | ||
| } |
| let mut bytes = [0x00; 32]; | ||
| bytes[31] = 0x10; | ||
| assert_eq(U256::into(big_number), bytes); | ||
| } |
There was a problem hiding this comment.
Some more tests pls :)
|
|
||
| #[test] | ||
| fn from_bytes32_zero() { | ||
| let mut bytes = [0x00; 32]; |
| global limit_u256 = U256 {high: limit, low:limit}; | ||
|
|
||
| #[test] | ||
| fn from_bytes32_zero() { |
There was a problem hiding this comment.
mod from_bytes32 {
}
mod into_bytes32 {
}|
|
||
| #[test] | ||
| fn from_bytes32_limit() { | ||
| let mut bytes = [0xff; 32]; |
marekkirejczyk
approved these changes
Jun 7, 2024
akonior
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Unnecessary import bytes32::field_to_bytes32 can be removed
|
|
||
| global TOKEN_BALANCE_INDEX = 0; | ||
|
|
||
| struct ERC20Token { | ||
| address: Address, | ||
| balances_slot: Bytes32, | ||
| allowances_slot: Bytes32, | ||
| balances_slot: U256, |
There was a problem hiding this comment.
Bytes32 import can be removed
akonior
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.