Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Print running script to enhance CI log readability #10594

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Nov 23, 2024

Some tests in CI involve executing Python scripts, making it difficult to quickly identify which script is causing failure. It is recommended to print script information before running such tests to help quickly locate the corresponding script.

@DarkLight1337

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 23, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 23, 2024 15:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 23, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use single quotes inside the yaml file since the content of this file is being expanded inside jinja template strings.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
auto-merge was automatically disabled November 23, 2024 16:02

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 23, 2024 16:20
@jeejeelee
Copy link
Collaborator Author

The output meets the expectations of this PR, and the example test failure also shows that #10450 is not the reason

@youkaichao
Copy link
Member

we should do it in the ci repo level , see vllm-project/buildkite-ci#52

@jeejeelee
Copy link
Collaborator Author

@youkaichao It looks like vllm-project/buildkite-ci#52 has implemented this functionality, right? If so, I will close this PR.

@youkaichao
Copy link
Member

@youkaichao It looks like vllm-project/buildkite-ci#52 has implemented this functionality, right? If so, I will close this PR.

let me check for some ci jobs

@DarkLight1337 DarkLight1337 merged commit 1c445dc into vllm-project:main Nov 24, 2024
69 checks passed
@jeejeelee
Copy link
Collaborator Author

@youkaichao @DarkLight1337
It seems that merging this branch into forked main triggered an automatic merge. I apologize, I didn't notice this point.​​​​​​​​​​​​​​​​

@youkaichao
Copy link
Member

no worry. i have reverted the change.

@jeejeelee jeejeelee deleted the optimize-ci-ouput branch November 25, 2024 02:44
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
…roject#10594)

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants