-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Print running script to enhance CI log readability #10594
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use single quotes inside the yaml file since the content of this file is being expanded inside jinja template strings.
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Head branch was pushed to by a user without write access
The output meets the expectations of this PR, and the example test failure also shows that #10450 is not the reason |
we should do it in the ci repo level , see vllm-project/buildkite-ci#52 |
@youkaichao It looks like vllm-project/buildkite-ci#52 has implemented this functionality, right? If so, I will close this PR. |
let me check for some ci jobs |
@youkaichao @DarkLight1337 |
no worry. i have reverted the change. |
…roject#10594) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
…roject#10594) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Some tests in CI involve executing Python scripts, making it difficult to quickly identify which script is causing failure. It is recommended to print script information before running such tests to help quickly locate the corresponding script.
@DarkLight1337