Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] update the code to add models #10603

Merged
merged 9 commits into from
Nov 24, 2024
Merged

[doc] update the code to add models #10603

merged 9 commits into from
Nov 24, 2024

Conversation

youkaichao
Copy link
Member

the doc has been outdated for a while.

@youkaichao
update doc
1ee3917 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
Merge branch 'main' into update_doc
3919074
@youkaichao
update
2fe183b 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
update
edb96cc 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 24, 2024
@youkaichao
update
7e8fda8 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
fix format
da9010e 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
fix code format
da41521 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
fix code format
c7d5d4a 
Signed-off-by: youkaichao <youkaichao@gmail.com>
DarkLight1337
DarkLight1337 approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

@youkaichao @DarkLight1337
Update docs/source/models/adding_model.rst
61657ef 
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
@youkaichao youkaichao merged commit e4fbb14 into vllm-project:main Nov 24, 2024
10 of 14 checks passed
@youkaichao youkaichao deleted the update_doc branch November 24, 2024 19:21
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@youkaichao @DarkLight1337 @mfournioux
[doc] update the code to add models (vllm-project#10603)
c104015 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@youkaichao @DarkLight1337
[doc] update the code to add models (vllm-project#10603)
22d0575 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @DarkLight1337