Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added contravariant instance for ConfigDecoder #514

Merged
merged 4 commits into from
Oct 17, 2021
Merged

Added contravariant instance for ConfigDecoder #514

merged 4 commits into from
Oct 17, 2021

Conversation

dimitarg
Copy link
Contributor

Let me know if this looks right / needed and I'll add tests.

vlovgr
vlovgr reviewed Oct 14, 2021
View reviewed changes
Copy link
Owner

@vlovgr vlovgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely looks right to me. Just need law tests before merging. :)

.gitignore Outdated Show resolved Hide resolved
modules/core/src/main/scala/ciris/ConfigDecoder.scala Outdated Show resolved Hide resolved
@dimitarg
Copy link
Contributor Author

Added spec, ready to review @vlovgr

@dimitarg dimitarg changed the title WIP - added contravariant instance for ConfigDecoder Added contravariant instance for ConfigDecoder Oct 16, 2021
@dimitarg dimitarg marked this pull request as ready for review October 16, 2021 10:19
@vlovgr
Copy link
Owner

vlovgr commented Oct 17, 2021

Thanks @dimitarg!

@vlovgr vlovgr merged commit cd11391 into vlovgr:master Oct 17, 2021
@dimitarg dimitarg deleted the contravariant branch February 24, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlovgr vlovgr vlovgr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitarg @vlovgr