Build ciris-enumeratum with Scala 3 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR cross builds ciris-enumeratum with Scala 3: * Scala 3 has been added to the enumeratum's `crossScalaVersions` * The `TypeNameRuntimePlatform` has been splitted for Scala 2 and Scala 3. The Scala 3 implementation has been copied from the refined module. * `-Yretain-trees` was added to the Scala 3 `scalacOptions` to fix test compilation errors: ``` sbt:ciris> enumeratumJVM/test [info] compiling 2 Scala sources to modules/enumeratum/jvm/target/scala-3.2.2/test-classes ... [error] -- Error: modules/enumeratum/shared/src/test/scala/enumeratum/values/CirisValueEnumSpec.scala:216:17 [error] 216 | val values = findValues [error] | ^^^^^^^^^^ [error] | Option -Yretain-trees must be set in scalacOptions. [error] | In SBT settings: [error] | [error] | scalacOptions += "-Yretain-trees" ``` It is expected that this must be set: https://github.com/lloydmeta/enumeratum/blob/1facfdddd9498411ac8eb270cd8089d4b4f4cab0/README.md?plain=1#L28
|
Many thanks for releasing this so quickly, @vlovgr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cross builds ciris-enumeratum with Scala 3:
crossScalaVersionsTypeNameRuntimePlatformhas been split for Scala 2 and Scala 3. The Scala 3 implementation has been copied from the refined module.-Yretain-treeswas added to the Scala 3scalacOptionsto fix test compilation errors:https://github.com/lloydmeta/enumeratum/blob/1facfdddd9498411ac8eb270cd8089d4b4f4cab0/README.md?plain=1#L28