Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for Archmage Tarsis Kir-Moldir 16381 #1948

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

MantisLord
Copy link
Contributor

CMaNGOS counterpart: cmangos/tbc-db@cc4efc8

🍰 Pullrequest

Archmage Tarsis is supposed to do a small script when the player first speaks with him. He closes the gossip menu, then kneels and sits before re-enabling gossip.
He also has a special interaction if the player has Frame of Atiesh (item 22727).

Proof

https://www.wowhead.com/classic/item=22727/frame-of-atiesh#comments:id=3297645
https://www.reddit.com/r/classicwow/comments/lc7eel/if_you_have_the_frame_of_atiesh_item_in_your_bags/
There was a video somewhere but I can't recall where. His regular gossip menu ids I used here are from classic sniffs.

Issues

Wrong gossip menu ids were used in the existing data, so I cleaned those up as well as some locales_gossip_menu_option data which looks old/irrelevant now with broadcast text locales.

How2Test

  • Go to Naxx, talk to Archmage and witness his glorious script happen the first time you speak with him.
  • Turn GM on or add Frame of Atiesh to see the alternate special gossip option and script.

Todo / Checklist

  • Add the special Frame of Atiesh interaction with Archmage Angela Dosantos 16116, maybe this one is missing as well.

@ratkosrb ratkosrb merged commit 991b1bc into vmangos:development Nov 15, 2023
3 of 4 checks passed
Benjaminmnoer pushed a commit to Benjaminmnoer/vmangoscore that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants