Make -march=native configurable.
#2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for portable builds by not targeting the local CPU specifically when the introduced `BUILD_FOR_HOST_CPU` option is turned off.
Benjaminmnoer
pushed a commit
to Benjaminmnoer/vmangoscore
that referenced
this pull request
Dec 18, 2023
This allows for portable builds by not targeting the local CPU specifically when the introduced `BUILD_FOR_HOST_CPU` option is turned off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
-march=nativetells the compiler to specifically optimize for the host CPU which makes it unlikely that the resulting executable will run on other CPU models. This is obviously not suitable for builds that are supposed to be portable/distributable.This PR introduces a new CMake option called
BUILD_FOR_HOST_CPUthat allows to control the usage of the-march=nativeflag. The default is that it does build with the flag so that it doesn't change the current behavior.Example use case: I provide prebuilt Docker images and currently have to patch out the
-march=nativeflag.Proof
Issues
How2Test
-DBUILD_FOR_HOST_CPU=0and observe that the-march=nativeflag is not usedTodo / Checklist