Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue were vmap extractor generates duplicate files on some systems #2833

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

Gamemechanicwow
Copy link
Contributor

@Gamemechanicwow Gamemechanicwow commented Nov 17, 2024

🍰 Pullrequest

Vmap extractor extract modelnames from references in adt tiles and gameobjectdisplayinfo.dbc. The referenced modelnames can differ in case sensitivity. Since linux has case sensitive filnames, this will - unlike windows - not be caught by fileexists() and 1100~ duplicate files will be generated.

This PR ensures that each modelname is referenced the same way.

  • First letter is uppercase
  • First letter after a non-alpha char is uppercase
  • Rest is lowercase including the filetype

Also: Doodads will now be stored in the same order in the dir_bin file.

Proof

  • None

Issues

  • None

How2Test

  • Extract maps and vmaps on different platforms
  • Diff check all files
  • The only difference after this PR should be the floating points stored in dir_bin for position and rotation. At most the difference will be +-0.000001

Todo / Checklist

  • None

@Gamemechanicwow
Copy link
Contributor Author

Gamemechanicwow commented Nov 17, 2024

marked as draft because even though - the extracted model files on linux now matches windows. I still need to analyze if it has any impacts on dir_bin and temp_gameobject_models.

@0blu 0blu added the CPP A issue / PR which references CPP code label Nov 20, 2024
@Gamemechanicwow Gamemechanicwow marked this pull request as ready for review December 7, 2024 15:09
@ratkosrb ratkosrb merged commit 4987b3e into vmangos:development Dec 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPP A issue / PR which references CPP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants