Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rate.Creature.*.SpellDamage #2840

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Stoabrogga
Copy link
Contributor

🍰 Pullrequest

Also apply the rate to melee/ranged spells, which are not weapon damage based, and spells from non-player pets.

Proof

  • None

Issues

How2Test

  • Change parameters, e.g.:
    • Rate.Creature.Normal.SpellDamage = 0.1
    • Rate.Creature.Elite.Elite.SpellDamage = 0.1
  • Fight against Patchwerk (Hateful Strike)
  • Fight against Living Monstrosity (Lightning Totem)

Todo / Checklist

  • None

Also apply to melee/ranged spells, which are not weapon damage based, and non-player pets.
@ratkosrb ratkosrb merged commit d56621b into vmangos:development Dec 9, 2024
3 checks passed
@Stoabrogga Stoabrogga deleted the rate_spelldamage branch December 9, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Creature damage configuration option does not apply to physical ranged attacks
2 participants