Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libboost requirement? #54

Closed
clickworkorange opened this issue Jun 4, 2018 · 2 comments
Closed

libboost requirement? #54

clickworkorange opened this issue Jun 4, 2018 · 2 comments
Labels
buildsys Build-time issue (cmake-related)

Comments

@clickworkorange
Copy link

clickworkorange commented Jun 4, 2018

Trying to compile this but it fails when not finding libboost:

In file included from /usr/include/yaml-cpp/node/node.h:16:0,
                 from /usr/include/yaml-cpp/yaml.h:16,
                 from /home/ola/Sources/thinkfan/src/yamlconfig.h:9,
                 from /home/ola/Sources/thinkfan/src/config.cpp:31:
/usr/include/yaml-cpp/node/ptr.h:11:32: fatal error: boost/shared_ptr.hpp: No such file or directory
compilation terminated.

However:

apt-get install libboost-dev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following additional packages will be installed:
  libboost1.58-dev
Suggested packages:
  libboost-doc libboost1.58-doc libboost-atomic1.58-dev libboost-chrono1.58-dev libboost-context1.58-dev libboost-coroutine1.58-dev libboost-date-time1.58-dev
  libboost-exception1.58-dev libboost-filesystem1.58-dev libboost-graph1.58-dev libboost-graph-parallel1.58-dev libboost-iostreams1.58-dev libboost-locale1.58-dev
  libboost-log1.58-dev libboost-math1.58-dev libboost-mpi1.58-dev libboost-mpi-python1.58-dev libboost-program-options1.58-dev libboost-python1.58-dev libboost-random1.58-dev
  libboost-regex1.58-dev libboost-serialization1.58-dev libboost-signals1.58-dev libboost-system1.58-dev libboost-test1.58-dev libboost-thread1.58-dev libboost-timer1.58-dev
  libboost-wave1.58-dev libboost1.58-tools-dev libmpfrc++-dev libntl-dev
The following NEW packages will be installed
  libboost-dev libboost1.58-dev
0 to upgrade, 2 to newly install, 0 to remove and 2 not to upgrade.
Need to get 6,225 kB of archives.
After this operation, 105 MB of additional disk space will be used.
Do you want to continue? [Y/n] HELL NO!
Abort.

A tad excessive, for fan control, isn't it? Also, this dependency isn't listed in the readme.

@clickworkorange
Copy link
Author

clickworkorange commented Jun 4, 2018

Never mind; desperate to get the fan to behave on my X200 so I installed the ~150Mb worth of dependencies to get this to build (i.e. cmake-curses, libboost-dev, etc). But it does rankle my minimalist sensibilities that such a small program has such big dependencies just for building. I also couldn't avoid installing libyaml-cpp even with -D USE_YAML:BOOL=False (make resulted in fatal error: yaml-cpp/yaml.h: No such file or directory). This all said, it does seem to be working, so thanks for the code! :)

@vmatare
Copy link
Owner

vmatare commented Jun 4, 2018

Well, if you look closely, boost is actually not a direct dependency of thinkfan, but of the libyamlcpp you have installed. Unfortunately, certain distros still ship some ancient versions of libyamlcpp, and in your case it's so old that it still uses boost::shared_ptr.

That said, thinkfan should of course compile fine with -D USE_YAML:BOOL=False, so I'm reopening this to remind myself to look into that.

@vmatare vmatare reopened this Jun 4, 2018
@vmatare vmatare added the buildsys Build-time issue (cmake-related) label Jul 15, 2018
vmatare pushed a commit that referenced this issue Jul 16, 2018
yamlconfig.h include was unguarded. Fixes issue #54.
@vmatare vmatare closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildsys Build-time issue (cmake-related)
Projects
None yet
Development

No branches or pull requests

2 participants