Dcmi management controller string support #4
Conversation
|
Thanks @connorgorman , looks good to me. I'd prefer to avoid using git submodules however, do you mind removing that part? Would rather vendor using a tool such as gvt, or even remove the dependency on testify and just using testing from stdlib. |
|
We should have also seen an automated CLA request from @vmwclabot |
|
@dougm Sounds good. I'll remove the dependency altogether |
|
@dougm the CLA bot is not turned on for this project. I'll get it enabled today. Drop me an e-mail if there are any other projects you want it enabled on. Thanks! |
|
@connorgorman, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
connorgorman
changed the title
|
@dougm I reverted the dependency management piece, but did leave the strechr dependency as I didn't see an easy way to decouple the project from it. Also, the CLA has been sent to Medallia's legal team. Thanks |
|
@connorgorman, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement. |
This reverts commit 2f5f539.
* Remove newlines received when ipmitool is used
Fix lanplus response
* It now supports multi chunks tags
* Accumulate the amount of bytes read and compare it to the amount of bytes to receive. Do not ask for more bytes if all bytes have been received
add stdout as part of error message
No description provided.