Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Change service port name to use prefix http #559

Closed
sayanh opened this issue Jan 19, 2018 · 3 comments
Closed

Change service port name to use prefix http #559

sayanh opened this issue Jan 19, 2018 · 3 comments

Comments

@sayanh
Copy link
Contributor

sayanh commented Jan 19, 2018

Feature
In order to integrate with Istio, the port name for a function service needs to be have a prefix http-. This enables Istio to discover function services, provided the envoy sidecar is already injected to function pod. Istio has a definite service port naming convention as mentioned here.

Named ports: Service ports must be named. The port names must be of the form [-] with http, http2, grpc, mongo, or redis as the in order to take advantage of Istio’s routing features. For example, name: http2-foo or name: http are valid port names, but name: http2foo is not. If the port name does not begin with a recognized prefix or if the port is unnamed, traffic on the port will be treated as plain TCP traffic (unless the port explicitly uses Protocol: UDP to signify a UDP port).

Implementation details
The implementation is pretty trivial with changing the names of the service ports to http-function-port.

@sayanh
Copy link
Contributor Author

sayanh commented Jan 19, 2018

Please consider this PR as a solution for this issue.

@sayanh sayanh closed this as completed Jan 19, 2018
@sayanh sayanh reopened this Jan 19, 2018
@ngtuna
Copy link
Contributor

ngtuna commented Jan 22, 2018

@sayanh is there anything you want to do more (why reopen) ? I am seeing the function port name has prefix http- already.

@sayanh
Copy link
Contributor Author

sayanh commented Jan 23, 2018

@ngtuna nothing more actually hence closing.

@sayanh sayanh closed this as completed Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants