This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Change service port name to use prefix http to support Istio #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Jan 22, 2018
There was a problem hiding this comment.
LGTM, this just need a documentation change. The main README requires to be updated:
README.md
149:$ curl -L --data '{"Another": "Echo"}' localhost:8080/api/v1/proxy/namespaces/default/services/get-python:function-port/ --header "Content-Type:application/json"
Note that this is also a breaking change since previous monitoring objects will require to be adapted. Just a note for whenever we do the next release.
|
@andresmgot documentation modified as suggested |
paolomainardi
pushed a commit
to paolomainardi/kubeless
that referenced
this pull request
Feb 3, 2018
…archive#560) * Change service port name to use prefix http to support Istio * Added http-function-port in documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: Issue 559
Description: Service port name is changed to
http-function-portTODOs: