This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Passing Container env variables to Compile container #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container env variable array was not passed to Compile Container method. This made all those environment variable missing in Compile container phase This is for issue 972
andresmgot
approved these changes
May 6, 2019
There was a problem hiding this comment.
the code LGTM @dheerajjoshim
I have tested it and works as expected. Anything else you need to check before merging this?
|
No. Nothing else to check. :) |
|
Once merging this. Can PR 968 be merged as well? It is for doc changes for Java maven options |
|
Cool, thanks @dheerajjoshim |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container env variable array was not passed to Compile Container method. This made all those environment variable missing in Compile container phase
This is for issue 972
Issue Ref: 972
Description: Container env variable array was not passed to Compile Container method. This made all those environment variable missing in Compile container phase
[PR Description]:Pass environment variables to compile phase of a Java function container