This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Add soft pod anti affinity #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2020 11:57
andresmgot
reviewed
Feb 20, 2020
There was a problem hiding this comment.
Thanks for the PR @d0x2f !
Regarding the documentation, maybe we can add a small note in docs/advanced-function-deployment.md, before the section Deploying large functions.
Add created-by label match requirement. Add small docs section.
|
Thanks again for reviewing @andresmgot |
andresmgot
approved these changes
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: None
Description:
Adds a soft pod anti affinity rule to function deployments so that, where possible, function pods are deployed to different nodes.
Being only a soft or "PreferredDuringSchedulingIgnoredDuringExecution" anti affinity rule it remains backwards compatible because if the rule can't be satisfied it'll fall back to the current behavior.
Some reading for those unfamiliar: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#inter-pod-affinity-and-anti-affinity
TODOs:
I'm unsure if this needs to be documented anywhere, point me in the right direction if it should be.