Doc fixen #1120

tych0 · 2020-03-16T20:33:38Z

Couple of minor typos in the documents where the text doesn't match the example.

The handler function is called "hello", but the docs here refer to it as "foobar". Signed-off-by: Tycho Andersen <tycho@tycho.ws>

The function is "foo", not "foobar. Signed-off-by: Tycho Andersen <tycho@tycho.ws>

tych0 · 2020-03-16T20:57:52Z

Failure seems unrelated?

go: sourcegraph.com/sourcegraph/go-diff@v0.5.0: unrecognized import path "sourcegraph.com/sourcegraph/go-diff" (parse https://sourcegraph.com/sourcegraph/go-diff?go-get=1: no go-import meta tags (meta tag localhost:3080/sourcegraph/go-diff did not match import path sourcegraph.com/sourcegraph/go-diff))
go: finding golang.org/x/net v0.0.0-20180826012351-8a410e7b638d
go: error loading module requirements

this doesn't change the go code at all.

andresmgot

Thanks for fixing the typos @tych0! Indeed the error in the CI is unrelated.

tych0 added 2 commits March 16, 2020 14:29

quick-start: fix name of handler in example

c8d0277

The handler function is called "hello", but the docs here refer to it as "foobar". Signed-off-by: Tycho Andersen <tycho@tycho.ws>

doc/runtimes: fix handler name in js example

30fd6d6

The function is "foo", not "foobar. Signed-off-by: Tycho Andersen <tycho@tycho.ws>

andresmgot approved these changes Mar 17, 2020

View reviewed changes

andresmgot merged commit 6d8a9d2 into vmware-archive:master Mar 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc fixen #1120

Doc fixen #1120

tych0 commented Mar 16, 2020

tych0 commented Mar 16, 2020

andresmgot left a comment

Doc fixen #1120

Doc fixen #1120

Conversation

tych0 commented Mar 16, 2020

tych0 commented Mar 16, 2020

andresmgot left a comment

Choose a reason for hiding this comment