This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
kubeless function deploy/update: add option to specify node selectors. #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Aug 20, 2020
|
Sorry @varunbpatil, this PR is ready to be merged but the CI is failing because an unrelated issue. There are several references in the file |
Will do. |
|
Hi @andresmgot , I've update the Makefile and CI is passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: #1156
Description:
Add a new option
--node-selectorsto thekubeless function deployandkubeless function updatecommands to specify node-selectors for the function.TODOs: