PHP runtime #581

paolomainardi · 2018-02-02T13:57:55Z

Issue Ref: None

Description:

PHP runtime implementation, still a working in progress.

[PR Description]

TODOs:

Make php controller to handle function timeout (maybe using something like pthreads.org)
Ready to review
Automated Tests
Docs

andresmgot

Thank you for working on this @paolomainardi ! I sent a few early comments.

andresmgot · 2018-02-05T08:54:10Z

docker/runtime/php-7.1/http-trigger/Controller.php

+  }
+
+  /**
+   * Heltz route.


small typo: Healtz route

healthz even

andresmgot · 2018-02-05T14:58:23Z

examples/php/helloGet.php

+function foo() {
+  print "hello world";
+}
+


we should have another example in which the data given in the request is used somehow.

Also you should add in the Makefile of the examples/ folder tasks to deploy and verify these examples. Note that there should be tasks there to verify that setting a custom port and timeouts work as expected.

Those tests will be executed in travis if you add them in the file ./tests/integration-tests.bats

Ok thanks @andresmgot, i'm going to add it in the next commit.

@andresmgot added a test with data and added to integration-tests.bats

rakesh-garimella · 2018-02-06T11:49:57Z

You would need to modify the langruntime.go and langruntime_test.go(see [PR #575 ]) We have moved the information about init images into kubeless-config.

paolomainardi · 2018-02-06T15:05:43Z

ok @rakesh-garimella

andresmgot · 2018-02-08T08:19:48Z

examples/Makefile

 get-php-deps:
 	kubeless function deploy get-php-deps --trigger-http --runtime php7.1 --handler hellowithdeps.foo --from-file php/hellowithdeps.php --dependencies php/composer.json
 	echo "curl localhost:8080/api/v1/proxy/namespaces/default/services/get-php-deps/"

+get-php-deps-verify:
+	kubeless function call get-php-deps | egrep "hello world"


instead of printing hello world for the test you can check the logs of the pod:

kubectl logs -l function=get-php-deps | egrep ...

You are totally right, let me change it.

…e sleep() to override it

paolomainardi · 2018-02-09T21:47:04Z

@andresmgot the MR can now be evaluated

andresmgot

Thank you @paolomainardi ! I just sent a few comments/questions.

andresmgot · 2018-02-12T08:25:27Z

docker/runtime/php-7.2/http-trigger/Controller.php

+  {
+    try {
+      $this->app->any('/', [$this, 'root']);
+      $this->app->any('/healtz', [$this, 'healtz']);


the path is /healthz the h is missing

Fixed, thanks

andresmgot · 2018-02-12T08:27:06Z

docker/runtime/php-7.2/http-trigger/timeout.php

@@ -0,0 +1,17 @@
+<?php


is this file needed? (it seems for debugging)

Not needed and removed

andresmgot · 2018-02-12T08:40:10Z

examples/Makefile

+
+post-php-verify:
+	kubeless function call post-php --data '{"it-s": "alive"}'| egrep "it.*alive"
+


we need one last test to check that the timeout is working as expected. Something like:

timeout-php: $(eval TMPDIR := $(shell mktemp -d)) printf '<?php\n function foo() { while(1) {} } }\n' > $(TMPDIR)/hello-loop.php kubeless function deploy timeout-php --trigger-http --runtime php7.2 --handler helloget.foo --from-file $(TMPDIR)/hello-loop.php --timeout 4 rm -rf $(TMPDIR) timeout-php-verify: $(eval MSG := $(shell kubeless function call timeout-php 2>&1 || true)) echo $(MSG) | egrep Request.timeout.exceeded

(you need to add this test to the integration-tests.bats file as well)

Thanks, added!

andresmgot · 2018-02-12T08:44:30Z

docker/runtime/php-7.2/http-trigger/Controller.php

+
+        return $response;
+      } else {
+          sleep($this->timeout);


does this let the parent process hanging? is it possible to serve other requests while this is "sleeping"?

Yes it's possible

To achieve that i had to use nginx because the php integrated webserver is just a plain single threaded process.

andresmgot · 2018-02-12T08:46:43Z

docker/runtime/php-7.2/http-trigger/Controller.php

+      } else {
+          sleep($this->timeout);
+          posix_kill($pid, SIGKILL);
+          throw new TimeoutFunctionException();


does this throw the exception even if the process were already finished at the time of posix_kill?

No the request dies when parent or child return a response

paolomainardi · 2018-02-13T20:48:08Z

@andresmgot the php image has been updated using both php-fpm+nginx, we can't rely just on PHP webserver as it is just one single thread process.

…upport multithread requests (retry job)

murali-reddy · 2018-02-15T07:08:39Z

@paolomainardi thanks for your patience in addressing all comments/suggestions. Overall looks good.

I think integration tests are almost complete. Would you mind adding a test similar to get-python-update to test the function update functionality? Should not take much of your time.

Here are some gaps I would like an issue opened so that someone can work on them or atleast we have issue to track pending items.

Support for custom port is missing.
Support for Prometheus metrics
Support for scheduled and Kafka support

paolomainardi · 2018-02-15T10:46:30Z

@murali-reddy update tests added and CI is green, thanks.
I would like to work on the issues you listed, do you think that can be merged in the meanwhile ?

murali-reddy

LGTM, pending issues can be addressed in separate PR's.

murali-reddy · 2018-02-15T11:17:59Z

I would like to work on the issues you listed, do you think that can be merged in the meanwhile ?

Great if you can raise PR for pending issue.

deckchairlabs · 2018-02-19T03:44:48Z

I would have thought using something like this would be more suited for PHP https://github.com/php-pm/php-pm instead of having an nginx process running.

andresmgot · 2018-02-19T09:24:07Z

@deckchairlabs I am not a PHP expert but it seems that php-pm uses Nginx as well under the hoods. It seems that it provides some performance benefits when using it with PHP frameworks or PHP-FPM (which is not our case AFAIK). Is there any specific advantage you were thinking of? We can raise a new issue and tackle that.

paolomainardi · 2018-02-19T09:57:44Z

Hi @deckchairlabs, as @andresmgot which specific advantage you were thinking off ? I choosed nginx+php-fpm which is a well known and production grade solution for deploying php apps, i knew php-pm (as well reactphp) but it solves specific use cases.

deckchairlabs · 2018-02-20T01:21:58Z

PHP-PM can be run standalone, and does not need the addition of a webserver. I'll see what I can come up with using this PR as a starting point, and will open a new PR with my results. I guess the advantage I can think of is that it would more like NodeJS, whether or not that is a good thing..... we shall see.

paolomainardi force-pushed the feature/php-runtime branch from 21ede8c to 6754cf7 Compare February 3, 2018 17:15

andresmgot reviewed Feb 5, 2018

View reviewed changes

paolomainardi force-pushed the feature/php-runtime branch from 126e3b1 to ffb839a Compare February 6, 2018 15:30

paolomainardi and others added 10 commits February 6, 2018 17:06

First commit php runtime

b8a86a3

update php runtime server, fix dev-guide

f37b6f3

refs #000: Fix psr2 coding style

c44313b

refs #000: Changed name to kubeless

32c039b

update php controller

90d97f6

Fix response status

9426f98

changed name to Controller

e018b96

add an example using dependencies

fad49ce

Fix healtz route typo

4532aae

updated langruntime to make use of configmap

9108593

paolomainardi force-pushed the feature/php-runtime branch from ffb839a to 9108593 Compare February 6, 2018 16:27

paolomainardi added 4 commits February 6, 2018 22:57

refator runFunction method just using plain include

9a97f4f

add composer.lock, fix include dir

83b6e51

Add an example using the request object

9fc3433

Adding tests to bats

42aae70

paolomainardi changed the title ~~WIP: PHP runtime~~ PHP runtime Feb 6, 2018

paolomainardi added 3 commits February 7, 2018 00:28

fixing case

22ff247

Fixing case

bd840e6

Add verify tasks

90b151a

andresmgot reviewed Feb 8, 2018

View reviewed changes

paolomainardi added 5 commits February 8, 2018 12:43

check the container logs instead of stdout

d63ad96

Using docker image hash to test travis

019020b

Timeout support

6a8a520

use just a basic set_time_limit but it does not prevent functions lik…

f151bbf

…e sleep() to override it

Use pcntl_fork to make a real timeout

ecbd725

paolomainardi added 2 commits February 10, 2018 01:07

php upgraded to 7.2

8d6bcb0

removed temp files

9b6e36d

andresmgot reviewed Feb 12, 2018

View reviewed changes

paolomainardi added 4 commits February 12, 2018 10:50

Fix healtz route

f011ba7

Update docker image sha

7d2918e

Adding php timeout integration tests

7999cdf

Fixing routing problem due this bug slimphp/Slim#2107

ac987de

Just use nginx as the webserver because the php native one does not s…

9967a43

…upport multithread requests (retry job)

paolomainardi force-pushed the feature/php-runtime branch from 220d477 to 9967a43 Compare February 13, 2018 21:14

paolomainardi added 3 commits February 13, 2018 22:32

Fix supported http verbs

0e60e09

Retry 5 times

845b97d

adding debug

f4c60da

paolomainardi force-pushed the feature/php-runtime branch from 4a98a6b to f4c60da Compare February 13, 2018 22:18

paolomainardi and others added 2 commits February 14, 2018 10:47

Change verify of get-php-deps function

0285915

Missing newline

11534e0

paolomainardi added 2 commits February 15, 2018 11:00

adding update tests functions

b687d3c

Move delete function

aef912c

murali-reddy approved these changes Feb 15, 2018

View reviewed changes

murali-reddy merged commit 5844c40 into vmware-archive:master Feb 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP runtime #581

PHP runtime #581

paolomainardi commented Feb 2, 2018 •

edited by andresmgot

Loading

andresmgot left a comment

andresmgot Feb 5, 2018

sebgoa Feb 5, 2018

andresmgot Feb 5, 2018 •

edited

Loading

paolomainardi Feb 6, 2018

paolomainardi Feb 6, 2018

rakesh-garimella commented Feb 6, 2018

paolomainardi commented Feb 6, 2018

andresmgot Feb 8, 2018

paolomainardi Feb 8, 2018

paolomainardi commented Feb 9, 2018

andresmgot left a comment

andresmgot Feb 12, 2018

paolomainardi Feb 12, 2018

andresmgot Feb 12, 2018

paolomainardi Feb 12, 2018

andresmgot Feb 12, 2018

paolomainardi Feb 12, 2018

andresmgot Feb 12, 2018

paolomainardi Feb 12, 2018

paolomainardi Feb 14, 2018

andresmgot Feb 12, 2018

paolomainardi Feb 12, 2018

paolomainardi commented Feb 13, 2018

murali-reddy commented Feb 15, 2018

paolomainardi commented Feb 15, 2018

murali-reddy left a comment

murali-reddy commented Feb 15, 2018

deckchairlabs commented Feb 19, 2018

andresmgot commented Feb 19, 2018

paolomainardi commented Feb 19, 2018

deckchairlabs commented Feb 20, 2018


		post-php-verify:
		kubeless function call post-php --data '{"it-s": "alive"}'\| egrep "it.*alive"

PHP runtime #581

PHP runtime #581

Conversation

paolomainardi commented Feb 2, 2018 • edited by andresmgot Loading

andresmgot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andresmgot Feb 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rakesh-garimella commented Feb 6, 2018

paolomainardi commented Feb 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paolomainardi commented Feb 9, 2018

andresmgot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paolomainardi commented Feb 13, 2018

murali-reddy commented Feb 15, 2018

paolomainardi commented Feb 15, 2018

murali-reddy left a comment

Choose a reason for hiding this comment

murali-reddy commented Feb 15, 2018

deckchairlabs commented Feb 19, 2018

andresmgot commented Feb 19, 2018

paolomainardi commented Feb 19, 2018

deckchairlabs commented Feb 20, 2018

paolomainardi commented Feb 2, 2018 •

edited by andresmgot

Loading

andresmgot Feb 5, 2018 •

edited

Loading