Remove --trigger-http flag

[andresmgot]

Issue Ref: None

Description:

With the triggers decoupling the function deploy --trigger-http flag of the deployment method should be removed because:

• The meaning has changed having a "HTTP trigger" now means having a ingress rule, the above flag was used specify if the trigger should use an HTTP or a Kafka endpoint.
• It is required to create a service first: If --trigger-http is specified and the service has not been created yet (because the function is still being created) the Ingress object cannot be created.

TODOs:

• Ready to review
• Automated Tests
• Docs

[murali-reddy]

LGTM

[gkarthiks]

sorry if I understood wrong.
Are you saying we cannot deploy a kubeless function with trigger type as http?

[murali-reddy]

@gkarthiks

This is part of refactoring work that will be part of next release. Kubeless will have CLI to manage triggers.

$ kubeless trigger --help
trigger command allows user to create, list, update, delete triggers running on Kubeless

Usage:
  kubeless trigger SUBCOMMAND [flags]
  kubeless trigger [command]

Available Commands:
  cronjob     cronjob trigger specific operations
  http        http trigger specific operations
  kafka       kafka trigger specific operations

Flags:
  -h, --help   help for trigger

Use "kubeless trigger [command] --help" for more information about a command.

HTTP triggers can managed through the new CLI.

$ kubeless trigger http
http trigger command allows user to create, list, update, delete http triggers running on Kubeless

Usage:
  kubeless trigger http SUBCOMMAND [flags]
  kubeless trigger http [command]

Available Commands:
  create      Create a http trigger
  delete      Delete a HTTP trigger
  list        list all HTTP triggers deployed to Kubeless
  update      Update a http trigger

Flags:
  -h, --help   help for http

Use "kubeless trigger http [command] --help" for more information about a command.

For convenience kubeless function deploy also creates triggers implicitly depending on the flags. This PR just removes the implicit creation of HTTP trigger. But you can still create and use http triggers through the kubeless trigger http CLI.

[gkarthiks]

@murali-reddy 👍 got it!