Add golang runtime #671
Add golang runtime #671
Conversation
Add docs
|
General comment. Perhaps we need to think also on the user feedback when function fails to compile. Right now if I give incorrect go code, pod deployment gets stuck in |
|
Agree, let me check if we can provide an easier way of debugging. |
|
|
||
| // Handling Functions | ||
| func health(w http.ResponseWriter, r *http.Request) { | ||
| w.Write([]byte("OK")) |
There was a problem hiding this comment.
Are we not going to handle the pod unhealthy case when go routine running the function times out, and runs forever?
There was a problem hiding this comment.
We cannot handle that using goroutines (it is not possible to kill/stop a goroutine from outside). The other option would be that the process kills itself when a timeout is reached (similar to what we do in NodeJS) forcing a restart of the pod. What do you think?
|
|
||
| USER 1000 | ||
|
|
||
| CMD [ "/kubeless/server" ] |
| ADD docker/runtime/golang/Gopkg.toml $GOPATH/src/controller/ | ||
| WORKDIR $GOPATH/src/controller/ | ||
| ADD docker/runtime/golang/kubeless.tpl.go $GOPATH/src/controller/ | ||
| RUN dep ensure |
There was a problem hiding this comment.
I don't have first hand experiance. But please see dep issues, there are plenty of issues where dep init/ensure gets stuck forever for various reasons. Does it make sense to have a time out?
There was a problem hiding this comment.
I think that it would be difficult to set the proper value, it would depend on the dependencies to install. A timeout of several minutes may be insufficient in some scenarios and a timeout of ~1h would not be that useful since whoever is using it would detect that something is not going well.
There was a problem hiding this comment.
Sure. We can not make decisions on what is right time out value. But just looking at dep issues dep ensure can get stuck various reason. But its not this PR's problem. As long as kubeless user can figure whats going wrong.
|
Overall LGTM. |
Issue Ref: #169
Description:
Add Golang as a supported runtime. Review docs for developing a new runtime.
TODOs: