This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Fix GKE build for CircleCI #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the oldest version supported on GKE now, I think
|
I'm just going by the |
|
Looks like this will make it green! |
|
thanks for the update! |
|
Welp, that didn't fix anything. |
|
This seems to error out because "return 1" is nonsense in this context, bash needs this to happen inside of a function in order for return to be permitted. It might make sense to
However, I'm not sure that's going to fix anything, since it seems to loop forever as a result of the return error and it doesn't really appear that GKE cluster is ever finally coming up after that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the oldest version supported on GKE now, I think
(1.8.10-gke.0)
TODOs: