Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Python wildcard route support #928

Merged

Conversation

DrMegavolt
Copy link
Contributor

@DrMegavolt DrMegavolt commented Oct 23, 2018

Hello,

Issue Ref: This is proposal to make function routing handling consistent

Description:
Node.js and other runtimes listen to wildcard route. Python is exception

this is how wildcard route is defined in the Bottle framework '/<:re:.*>'
bottlepy/bottle#178

@andresmgot
Copy link
Contributor

Hi @DrMegavolt,

I'm curious about your use case. It seems to me that the bug is more about supporting random paths in the NodeJS runtime. Why do you need this?

@DrMegavolt
Copy link
Contributor Author

@andresmgot
In https://www.lunchbadger.com we use kubeless for serverless part.
User can add a Gateway and forward any URL to backend part (kubeless function in this case)

So the if method is GET then function itself can access query and routing parameters.

As of now we specifically set path to / when routing to function. However, this means that only POST\PUT make sense, because for GET\DELETE user cannot set any parameters

@andresmgot
Copy link
Contributor

Understood, thanks for the explanation. I agree it could be a good addition. I've just build the images for the different python versions and I added it to this PR. Do you mind rebasing master to fix the CI issue?

@DrMegavolt DrMegavolt force-pushed the python_listen_to_wildcard_route branch from 7bbd660 to d12f175 Compare October 24, 2018 13:49
@DrMegavolt
Copy link
Contributor Author

@andresmgot I've rebased the changes

@andresmgot andresmgot merged commit e48a7c9 into vmware-archive:master Oct 25, 2018
@andresmgot
Copy link
Contributor

Thanks for the changes! I am merging this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants