Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Upgrade to go 1.11 and convert to modules #997

Closed
wants to merge 4 commits into from

Conversation

gimlet2
Copy link
Contributor

@gimlet2 gimlet2 commented Feb 4, 2019

Issue Ref: None

Description:
This is proposal to upgrade project to go 1.11 and convert to modules for dependencies management.

TODOs:

  • Ready to review
  • Automated Tests
  • Docs

@andresmgot
Copy link
Contributor

Hi @gimlet2, can you add a bit of context to this PR? Upgrading Go is a logic movement but using modules is not that clear to me. I am reluctant to change the package system again (we used glide in the past) mostly because dep is also used in the Golang runtime functions and that would be inconsistent.

@gimlet2
Copy link
Contributor Author

gimlet2 commented Feb 5, 2019

Hi @andresmgot! It is just a proposal. I'm personally not a go developer and for me it is always an issue to setup go project correctly with all those GOPATH, GOROOT, etc.. But recently I've found that it is way simplier if you use go modules. With modules you can just checkout the code in some folder and build it. And you don't need to install additional software - it is already there with go package preinstalled. It supports automatic migration from dep. But I'm facing an issue with CircleCI to make it work =. Feel free to reject it, but for me it looks like go modules is a big step forward in go ecosystem. And I've used dep in the past for my projects too, but I did migrate all of them already.

@andresmgot
Copy link
Contributor

I see, it's indeed a nice feature that this PR has removed 800k lines of code. Apparently modules is still in the experimental phase (until Go v1.13), let's wait at least until v1.12 to add it.

BTW, the tests seem to fail because GOPATH is still needed to build the controller.

If you still want to update go to 1.11 please update this PR, in other case we can tackle that in a different PR.

@gimlet2 gimlet2 mentioned this pull request Feb 6, 2019
3 tasks
@gimlet2
Copy link
Contributor Author

gimlet2 commented Feb 6, 2019

Here is pull request with update of go to 1.11 only #998

@gimlet2 gimlet2 closed this Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants