-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Debian 11 machine image #195
Conversation
c3475cc
to
b34a98b
Compare
1f21b48
to
d7aedae
Compare
d7aedae
to
dec741c
Compare
dec741c
to
6049bdc
Compare
@tenthirtyam : i've improved my pull request aligning all the configurations and files where Debian should be listed. I've not manually edited the build.sh script manually but instead edited the build.yml template so that you will be able just to re-generate the build.s script when you will eventually integrate the pull request. Thank you |
Thanks, @evilaliv3! 🚀 Have you reviewed the Ansible roles to see if any changes are needed specifically for Debian or reuse between Debian and Ubuntu? Ryan Johnson |
You are welcome @tenthirtyam At the moment not as i'm new to ansible in general an learning it now through this valid set of examples. As a feedback as user of your scripts and examples in my opinion your set of examples are such a great resource but too way much complete; i would probably avoid to include such reach set of ansible playbook but just guide and instruct users with few examples. In my scenario for example I'm looking at this repo to automate the preparation of few virtual machines templates and to use this repository i need to forkit it because in your examples you install many tools like git, curl, and bash-completion that are not needed in our production systems but in this way we wont be able to easily pull back your updates. I would like instead to have an easy scaffolding that i could use directly being able to fetch the upstream updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No immediate concerns after reviewing the changes - follows the project de facto standards. I'll review the Ansible portions soon and aim to skip this into the next release.
Ryan Johnson
Staff II Solutions Architect | VMware, Inc.
Generated from `build.yaml`.
Sets the interpreter to `ANSIBLE_PYTHON_INTERPRETER=/usr/bin/python3` in the Ansible provisioner.
Adds the `python3-apt` package needed for the Ansible provisioner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The locals
for the data_source_command
will need to be added and tested.
Example:
locals {
#....
data_source_command = var.common_data_source == "http" ? "url=http://{{ .HTTPIP }}:{{ .HTTPPort }}/ks.cfg" : "file=cdrom:/ks.cfg"
}
|
Guest automatically resets from
Opening up an internal issue to review and resolve this issue before committing this feature as it needs to support both traditional template and OVF template in the content library. In the meantime, I'll work on addressing the gaps for Ansible and the CD-based kickstart while this is tracked internally. Label: Ryan Johnson |
For now, moving from Ryan Johnson |
Thank you @tenthirtyam for the update. Which are the current issues that you would like to fix? |
Hey @evilaliv3 - the outstanding items include:
Ryan Johnson |
Sets to OS to `other4xLinux64Guest`
Add perl to package configuration. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
I have a fix for this issue that will be addressed in the Ansible playbook. TL;DR:
[guestosinfo]
short-name = other4xLinux64Guest
This will be HTTP-only for the first inclusion, much like SLES 15. We can add the Ryan Johnson |
Update to current structure. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Update to current structure. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've resolved all conflicts and have brought the configurations up-to-date to the current structure. After merge into main
, I'll merge in the changes for the Ansible playbooks which are already ready.
Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.
Merged! 🚀 Ryan Johnson |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Summary of Pull Request
With this pull request, I would like to propose the addition of a Debian 11 machine. The code produced starts from the scripts already loaded in the repository for Ubuntu and preserves the same exact configuration.
Type of Pull Request
Please describe:
Closes #194
Test and Documentation Coverage
Breaking Changes?