Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gh-197 #198

Merged
merged 2 commits into from
Apr 13, 2022
Merged

fix: gh-197 #198

merged 2 commits into from
Apr 13, 2022

Conversation

evilaliv3
Copy link
Contributor

@evilaliv3 evilaliv3 commented Apr 13, 2022

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Fix issue GH-197 as discussed in the issue.

Type of Pull Request

  • This is a bugfix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #197

Test and Documentation Coverage

  • Tests have been completed (for bugfixes / features).
  • Documentation has been added / updated (for bugfixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
Copy link
Collaborator

Hi @evilaliv3! 👋

Can you complete the pull request template, please?

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@tenthirtyam tenthirtyam changed the title Fix issue vmware-samples/packer-examples-for-vsphere/issues/197 fix: gh-197 Apr 13, 2022
@tenthirtyam tenthirtyam self-assigned this Apr 13, 2022
@tenthirtyam tenthirtyam self-requested a review April 13, 2022 16:18
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch needs to be rebased to upstream main so that Ubuntu 22.04 changes are also made.

@evilaliv3
Copy link
Contributor Author

rebased!

Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@tenthirtyam
Copy link
Collaborator

Awaiting completion of the pull request template and the run of the GHA before merging.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@tenthirtyam
Copy link
Collaborator

I've updated the pull request with the completed template.

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.

@tenthirtyam tenthirtyam merged commit 4636c50 into vmware-samples:main Apr 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Setting the build_password using set-envvars.sh
2 participants