Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add privilege #295

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix: add privilege #295

merged 1 commit into from
Oct 24, 2022

Conversation

tenthirtyam
Copy link
Collaborator

Summary of Pull Request

Adds a known. but missing privilege to README.md configuration section and the Terraform example for a custom vSphere role.

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

#293

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

fix: add privilege
14bf38a 
Adds a known. but missing privilege to `README.md` configuration section and the Terraform example for a custom vSphere role.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added type/bug Bug type/docs Documentation labels Oct 24, 2022
@tenthirtyam tenthirtyam added this to the v22.11 milestone Oct 24, 2022
@tenthirtyam tenthirtyam self-assigned this Oct 24, 2022
tenthirtyam
tenthirtyam commented Oct 24, 2022
View reviewed changes
Copy link
Collaborator Author

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit 0dd8927 into main Oct 24, 2022
@tenthirtyam tenthirtyam deleted the fix/add-privilege branch October 24, 2022 16:47
tenthirtyam pushed a commit that referenced this pull request Nov 8, 2022
docs: update CHANGELOG.md
b333b00 
Updates `CHANGELOG.md` to include fixes in GH-295, GH-339, and GH-340.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
@tenthirtyam tenthirtyam added the area/terraform Area: Terraform label Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tenthirtyam tenthirtyam

Labels
area/terraform Area: Terraform type/bug Bug type/docs Documentation
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
1 participant
@tenthirtyam