Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update syntax to append algorithm #386

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Nov 29, 2022

Summary of Pull Request

You just want to append the algorihm ssh-rsa instead of replacing already existing algorithms.

Otherwise services like GitHub might complain about unsupported algorithms.

➜ git pull
ERROR: You're using an RSA key with SHA-1, which is no longer allowed. Please use a newer client or a different key type.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@dhoppe dhoppe requested a review from a team as a code owner November 29, 2022 10:54
@tenthirtyam tenthirtyam changed the title docs: Use correct syntax to append algorithm docs: update syntax to append algorithm Nov 29, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit 45fead1 into vmware-samples:main Nov 29, 2022
@tenthirtyam tenthirtyam added the type/docs Documentation label Nov 29, 2022
@tenthirtyam tenthirtyam added this to the v22.11 milestone Nov 29, 2022
@dhoppe dhoppe deleted the ssh_config branch November 29, 2022 11:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants