Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove country code for ubuntu #421

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Dec 12, 2022

Summary of Pull Request

The uri should not contain a country code like us. Otherwise the GeoIP lookup does not work.

deb http://us.archive.ubuntu.com/ubuntu jammy main restricted
vs
deb http://de.archive.ubuntu.com/ubuntu jammy main restricted

https://github.com/canonical/subiquity/blob/main/documentation/autoinstall-reference.md?plain=1#L214

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@dhoppe dhoppe requested a review from a team as a code owner December 12, 2022 19:38
@tenthirtyam tenthirtyam added the type/bug Bug label Dec 12, 2022
@tenthirtyam tenthirtyam added this to the .Next milestone Dec 12, 2022
@tenthirtyam tenthirtyam changed the title fix: Remove the country code to make the GeoIP lookup work fix: remove country code for ubuntu Dec 12, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit 6e18a20 into vmware-samples:main Dec 12, 2022
@dhoppe dhoppe deleted the apt_geoip branch December 12, 2022 20:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants