[Windows] Support run antrea-agent directly from scripts #1013

ruicao93 · 2020-07-31T06:37:47Z

Currently Antrea runs antrea-agent and kube-proxy from management
Pods. But there is still need to run these two components directly
using scripts. This patch:

Adds scripts help to install and run antrea-agent and kube-proxy.
Supports read kubeconfig from file for antrea-agent apiserver,
which is needed when antrea-agent is running as process.

Signed-off-by: Rui Cao rcao@vmware.com

antrea-bot · 2020-07-31T06:37:58Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2020-07-31T07:20:50Z

/test-all

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2020-07-31T08:10:51Z

/test-all

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2020-08-04T02:22:23Z

/test-all

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2020-08-06T05:45:54Z

/test-all

docs/windows.md

hack/windows/Helper.psm1

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

antoninbas

Is there any plan to validate this script in CI?

docs/windows.md

hack/windows/Helper.psm1

antoninbas · 2020-08-06T20:14:13Z

docs/windows.md

+```
+mkdir c:\k\antrea
+cd c:\k\antrea
+curl.exe -LO https://raw.githubusercontent.com/vmware-tanzu/antrea/master/hack/windows/Start.ps1


do you think we should have Start.ps1 in the release assets and that it should take care of pulling / starting the correct version of Antrea?

Yes, I think it's a good advice.

I can update upload_release_assets.yaml in next patch to add following files in assets:

Start.ps1

antrea-agent-windows-x86_64.exe

antrea-cni-windows-x86_64.exe

Sounds good. You can look at it in a follow-up patch.

hack/windows/Start.ps1

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2020-08-07T13:53:33Z

Is there any plan to validate this script in CI?

Yes @antoninbas , I'm working with Zhecheng to add CI for the scripts.

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Support read kubeconfig from file for antrea-agent apiserver. Which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

reachjainrahul · 2020-08-10T05:55:46Z

@jianjuns @antoninbas Do we need to support this workflow? If I understand, it requires access to worker node. The script will download and install Antrea and run it as process on the node, which is different than running Antrea as POD.
He need to understand its implication on upgrade, support bundle, log collection etc.

Lets have a offline meeting to discuss this. ?

ruicao93 · 2020-08-10T14:05:47Z

@jianjuns @antoninbas Do we need to support this workflow? If I understand, it requires access to worker node. The script will download and install Antrea and run it as process on the node, which is different than running Antrea as POD.
He need to understand its implication on upgrade, support bundle, log collection etc.

Lets have a offline meeting to discuss this. ?

Currently suportbundle/log collection is not supported if antrea-agent is run as process directly. And we also don't provide a specific script for upgrade.

In my opinion, in consideration of the different requirements among different platforms, the scripts we provide is more like a template to guide how to run antrea-agent as process if antrea-agent Pod is not allowed. It's hard to cover all functions as we support for Pod management. The platforms which integrated with Antrea may need custmize thire own scripts/solution based on the scripts/functions we provide.

Looing forward tto hear he ideas from Jianjun and Antonin.

jianjuns

In commit message:

Support read kubeconfig from file for antrea-agent apiserver.
Which is needed when antrea-agent is running as process.
Support -> Supports
Which -> which

jianjuns · 2020-08-10T17:08:21Z

I think process mode is not the recommended way.
However, I thought we need this mode for AKS Engine, then do we need to support upgrade? Even no upgrade, it will still be good to have support bundle for AKS Engine.
@reachjainrahul @ruicao93

reachjainrahul · 2020-08-10T17:42:56Z

I think process mode is not the recommended way.

However, I thought we need this mode for AKS Engine, then do we need to support upgrade? Even no upgrade, it will still be good to have support bundle for AKS Engine.

@reachjainrahul @ruicao93

Actually AKS engine folks asked if we can remove wins dependency as they don't want to add lot of components on windows host. However, if wins dependency is must and adding a script is the only alternative, than I would prefer to reach out to them again and mention why wins is needed. We would prefer not to add antrea as a process.

jianjuns · 2020-08-10T18:09:38Z

I think process mode is not the recommended way.
However, I thought we need this mode for AKS Engine, then do we need to support upgrade? Even no upgrade, it will still be good to have support bundle for AKS Engine.
@reachjainrahul @ruicao93

Actually AKS engine folks asked if we can remove wins dependency as they don't want to add lot of components on windows host. However, if wins dependency is must and adding a script is the only alternative, than I would prefer to reach out to them again and mention why wins is needed. We would prefer not to add antrea as a process.

If that is the case, please talk to AKS guys again. Definitely I want not to support process mode. But on the other hand, I feel this PR has nothing wrong. We just document a manual way to run Antrea agent. Does not mean we commit anything.

antoninbas · 2020-08-10T18:35:05Z

I agree with Jianjun. Let's hold off on adding additional support for this process mode though (e.g. support bundle). Maybe @ruicao93 can emphasize the limitations of this mode in the doc as well.

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Supports read kubeconfig from file for antrea-agent apiserver, which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

antrea-bot · 2020-08-11T02:55:39Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Supports read kubeconfig from file for antrea-agent apiserver, which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2020-08-11T03:25:58Z

In commit message:

Support read kubeconfig from file for antrea-agent apiserver.
Which is needed when antrea-agent is running as process.
Support -> Supports
Which -> which

Done.

ruicao93 · 2020-08-11T03:37:37Z

I agree with Jianjun. Let's hold off on adding additional support for this process mode though (e.g. support bundle). Maybe @ruicao93 can emphasize the limitations of this mode in the doc as well.

Sure, I will add the limitations in doc.

ruicao93 · 2020-08-11T03:38:22Z

/test-all

ruicao93 · 2020-08-11T06:54:47Z

/test-windows-conformance

ruicao93 · 2020-08-11T08:19:05Z

/test-windows-conformance

wenyingd

LGTM

) Currently Antrea runs antrea-agent and kube-proxy from management Pods. But there is still need to run these two components directly using scripts. This patch: - Adds scripts help to install and run antrea-agent and kube-proxy. - Supports read kubeconfig from file for antrea-agent apiserver, which is needed when antrea-agent is running as process. Signed-off-by: Rui Cao <rcao@vmware.com>

vmwclabot added the cla-not-required label Jul 31, 2020

ruicao93 force-pushed the scripts branch from 94f13ca to 21189d0 Compare July 31, 2020 06:40

ruicao93 force-pushed the scripts branch from 21189d0 to 62ef3bf Compare July 31, 2020 07:29

ruicao93 force-pushed the scripts branch from 62ef3bf to f41eb4e Compare July 31, 2020 07:43

ruicao93 force-pushed the scripts branch from f41eb4e to a4d3139 Compare July 31, 2020 09:06

ruicao93 requested a review from wenyingd July 31, 2020 09:13

ruicao93 force-pushed the scripts branch from a4d3139 to d642880 Compare July 31, 2020 11:05

ruicao93 force-pushed the scripts branch from d642880 to 496a5f0 Compare August 3, 2020 07:45

ruicao93 force-pushed the scripts branch from 496a5f0 to 2f511d1 Compare August 3, 2020 08:45

ruicao93 added this to the Antrea v0.9.0 release milestone Aug 4, 2020

ruicao93 force-pushed the scripts branch from 2f511d1 to 5dccb78 Compare August 5, 2020 01:10

wenyingd reviewed Aug 6, 2020

View reviewed changes

ruicao93 force-pushed the scripts branch from 5dccb78 to 3e92218 Compare August 6, 2020 10:03

antoninbas reviewed Aug 6, 2020

View reviewed changes

ruicao93 force-pushed the scripts branch from 3e92218 to d2b03a9 Compare August 7, 2020 13:50

ruicao93 force-pushed the scripts branch from d2b03a9 to 983a329 Compare August 8, 2020 04:19

jianjuns reviewed Aug 10, 2020

View reviewed changes

ruicao93 force-pushed the scripts branch from 983a329 to 6a9c3b6 Compare August 11, 2020 02:55

ruicao93 force-pushed the scripts branch from 6a9c3b6 to e393fd6 Compare August 11, 2020 02:59

ruicao93 force-pushed the scripts branch from e393fd6 to fa33909 Compare August 11, 2020 03:38

wenyingd approved these changes Aug 11, 2020

View reviewed changes

ruicao93 merged commit 649d174 into antrea-io:master Aug 11, 2020

This was referenced Aug 11, 2020

[Windows] Add CI support to verify Windows startup scripts #1064

Closed

Add release assets for Windows #1061

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Windows] Support run antrea-agent directly from scripts #1013

[Windows] Support run antrea-agent directly from scripts #1013

ruicao93 commented Jul 31, 2020 •

edited

Loading

antrea-bot commented Jul 31, 2020

ruicao93 commented Jul 31, 2020

ruicao93 commented Jul 31, 2020

ruicao93 commented Aug 4, 2020

ruicao93 commented Aug 6, 2020

antoninbas left a comment

antoninbas Aug 6, 2020

ruicao93 Aug 7, 2020

antoninbas Aug 7, 2020

ruicao93 commented Aug 7, 2020

reachjainrahul commented Aug 10, 2020

ruicao93 commented Aug 10, 2020 •

edited

Loading

jianjuns left a comment

jianjuns commented Aug 10, 2020

reachjainrahul commented Aug 10, 2020

jianjuns commented Aug 10, 2020

antoninbas commented Aug 10, 2020

antrea-bot commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

wenyingd left a comment

[Windows] Support run antrea-agent directly from scripts #1013

[Windows] Support run antrea-agent directly from scripts #1013

Conversation

ruicao93 commented Jul 31, 2020 • edited Loading

antrea-bot commented Jul 31, 2020

ruicao93 commented Jul 31, 2020

ruicao93 commented Jul 31, 2020

ruicao93 commented Aug 4, 2020

ruicao93 commented Aug 6, 2020

antoninbas left a comment

Choose a reason for hiding this comment

antoninbas Aug 6, 2020

Choose a reason for hiding this comment

ruicao93 Aug 7, 2020

Choose a reason for hiding this comment

antoninbas Aug 7, 2020

Choose a reason for hiding this comment

ruicao93 commented Aug 7, 2020

reachjainrahul commented Aug 10, 2020

ruicao93 commented Aug 10, 2020 • edited Loading

jianjuns left a comment

Choose a reason for hiding this comment

jianjuns commented Aug 10, 2020

reachjainrahul commented Aug 10, 2020

jianjuns commented Aug 10, 2020

antoninbas commented Aug 10, 2020

antrea-bot commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

ruicao93 commented Aug 11, 2020

wenyingd left a comment

Choose a reason for hiding this comment

ruicao93 commented Jul 31, 2020 •

edited

Loading

ruicao93 commented Aug 10, 2020 •

edited

Loading