Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce hierarchical chart changes ordering #151

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Enforce hierarchical chart changes ordering #151

merged 6 commits into from
Apr 20, 2022

Conversation

josvazg
Copy link
Contributor

@josvazg josvazg commented Apr 19, 2022

groupChangesByChart was returning a map but we expected the result sto be ordered, in particular hierarchical ordered preferably.

This change turns groupChangesByChart into orderedChangesByChart by taking the mp generated before and passing it to orderByChartHierarchy which builds an array of ChartChanges and enforces the expected hierarchical order leveraging the chart full path: least deep paths go first, at the same depth level order alphabetically.

Signed-off-by: Jose Luis Vazquez Gonzalez josvaz@vmware.com

Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
@josvazg josvazg requested a review from petewall April 19, 2022 16:39
@josvazg josvazg self-assigned this Apr 19, 2022
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
@vmwclabot
Copy link

@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
@vmwclabot
Copy link

@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josvazg josvazg merged commit c529788 into main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants