-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce hierarchical chart changes ordering #151
Conversation
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
groupChangesByChart
was returning a map but we expected the result sto be ordered, in particular hierarchical ordered preferably.This change turns
groupChangesByChart
intoorderedChangesByChart
by taking the mp generated before and passing it toorderByChartHierarchy
which builds an array ofChartChanges
and enforces the expected hierarchical order leveraging the chart full path: least deep paths go first, at the same depth level order alphabetically.Signed-off-by: Jose Luis Vazquez Gonzalez josvaz@vmware.com