Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix also the linter warnings #211

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: fix also the linter warnings #211

merged 1 commit into from
Nov 6, 2023

Conversation

tompizmor
Copy link
Member

@tompizmor tompizmor commented Nov 6, 2023

At #210 I fixed some errors returning by the linter action in the main branch. However, it seems for that action to pass, we should also fix the warnings.

  Warning: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: redefines-builtin-id: redefinition of the built-in function close (revive)
  Warning: redefines-builtin-id: redefinition of the built-in function close (revive)
  Warning: unused-parameter: parameter 'format' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'log' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'log' seems to be unused, consider removing or renaming it as _ (revive)

Signed-off-by: Tomas Pizarro Moreno <tpizarro@vmware.com>
@tompizmor tompizmor merged commit c5efdb6 into main Nov 6, 2023
1 check passed
@tompizmor tompizmor deleted the fix-warning-linter branch November 6, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants