WIP first conditions done

pkg/apis/v1alpha1/pipeline.go

@@ -25,8 +25,15 @@ import (
 
 const (
 	PipelineReady = "Ready"
+	RunTemplateReady = "RunTemplateReady"
 )
 
+const (
+	ReadyRunTemplateReason    = "Ready"
+	NotFoundRunTemplateReason = "RunTemplateNotFound"
+)
+
+
 // +kubebuilder:object:root=true
 
 type Pipeline struct {

pkg/apis/v1alpha1/run_template.go

@@ -23,15 +23,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 )
 
-const (
-	RunTemplateReady = "Ready"
-)
-
-const (
-	ReadyRunTemplateReason    = "Ready"
-	NotFoundRunTemplateReason = "RunTemplateNotFound"
-)
-
 // +kubebuilder:object:root=true
 
 type RunTemplate struct {

pkg/controller/pipeline/reconciler.go

@@ -51,11 +51,12 @@ func (r *Reconciler) realize(request ctrl.Request, logger logr.Logger)  {
 	})
 
 	if err != nil {
-		logger.Error(err, fmt.Sprintf("could not get RunTemplate '%s'", pipeline.Spec.RunTemplateName))
+		errorMessage := fmt.Sprintf("could not get RunTemplate '%s'", pipeline.Spec.RunTemplateName)
+		logger.Error(err, errorMessage)
 
-		conditionManager.AddPositive(RunTemplateMissingCondition(err))
+		conditionManager.AddPositive(RunTemplateMissingCondition(fmt.Errorf("%s: %w",errorMessage,err)))
 		pipeline.Status.Conditions, _ = conditionManager.Finalize()
-		_ = r.Repository.StatusUpdate(pipeline)
+		_ = r.Repository.StatusUpdate(pipeline) // FIXME: deal with errors!
 
 		return
 	}

pkg/controller/pipeline/reconciler_test.go

@@ -169,17 +169,17 @@ var _ = FDescribe("Reconcile", func() {
 				Expect(statusObject.Name).To(Equal("my-pipeline"))
 
 				Expect(statusObject.Status.Conditions).To(ContainElements(
-					MatchFields(0, Fields{
+					MatchFields(IgnoreExtras, Fields{
 						"Type":    Equal("Ready"),
 						"Status":  Equal(metav1.ConditionFalse),
-						"Reason":  Equal("RunTemplateNotFound"),
-						"Message": Equal("could not get RunTemplate 'my-run-template'"),
+						"Reason":  Equal("ConditionsUnmet"),
+						"Message": Equal("not all conditions are met"),
 					}),
-					MatchFields(0, Fields{
+					MatchFields(IgnoreExtras, Fields{
 						"Type":    Equal("RunTemplateReady"),
 						"Status":  Equal(metav1.ConditionFalse),
 						"Reason":  Equal("RunTemplateNotFound"),
-						"Message": Equal("could not get RunTemplate 'my-run-template'"), // fixme full error?
+						"Message": Equal("could not get RunTemplate 'my-run-template': Errol mcErrorFace"),
 					}),
 				))
 			})