-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce pipeline #17
Conversation
158f2f8
to
be1542f
Compare
- makes room for other controller-managed reconcilers [#6]
a621a39
to
7332bf8
Compare
1886c35
to
b915a98
Compare
Use Returns instead of Stubs
# Conflicts: # pkg/repository/repository.go
Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
have you been able to consistently run the integration tests? I quite often hit this snag
seems like there's some big flakiness there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments, mostly nitpicking, but if there's one thing I'd take a deeper look into is the requirement of kind
and namespace
in the runTemplateRef
- I think kind
should not exist and namespace
should be optional defaulting to default
let me know what you think 😁 good stuff! thx!
Co-authored-by: Waciuma Wanjohi <lwanjohi@vmware.com>
[#6] Co-authored-by: Waciuma Wanjohi <lwanjohi@pivotal.io> Co-authored-by: Emily Johnson <emjohnson@vmware.com>
[#6] Co-authored-by: Waciuma Wanjohi <lwanjohi@pivotal.io> Co-authored-by: Emily Johnson <emjohnson@vmware.com>
[#6] Co-authored-by: Waciuma Wanjohi <lwanjohi@pivotal.io> Co-authored-by: Emily Johnson <emjohnson@vmware.com>
So this is indeed not flakey and just a real failure. The update status call is requeueing the pipeline for reconcillation. This is in turn creating another stamped resource for the runtemplate. This is probably an infinite cycle. We will address this in very next PR. 😔 Making the test "pass" for now. |
Introduce pipeline.
closes #6
Currently blocked on: #16