Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment/live editor #639

Merged
merged 17 commits into from
Feb 23, 2022
Merged

Experiment/live editor #639

merged 17 commits into from
Feb 23, 2022

Conversation

squeedee
Copy link
Member

@squeedee squeedee commented Feb 17, 2022

Live editor blog post, all in one repo.

[updates #566]

@netlify
Copy link

netlify bot commented Feb 17, 2022

✔️ Deploy Preview for elated-stonebraker-105904 ready!

🔨 Explore the source changes: 1117acb

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/62150334486af90008915028

😎 Browse the preview: https://deploy-preview-639--elated-stonebraker-105904.netlify.app

@squeedee squeedee force-pushed the experiment/live-editor branch from 06bf4f6 to fd73877 Compare February 18, 2022 22:22
@squeedee squeedee force-pushed the experiment/live-editor branch from fd73877 to 4edb4aa Compare February 18, 2022 22:53
@squeedee squeedee marked this pull request as ready for review February 20, 2022 01:35
@squeedee squeedee force-pushed the experiment/live-editor branch from 0f752d2 to 1117acb Compare February 22, 2022 15:37
@squeedee
Copy link
Member Author

I've reset the branch to where the code matches the published editor. Preview is now the correct version

@davidmirror-ops
Copy link
Contributor

Thanks for this Rash

What I'm missing (and I think I saw in previous commits) is:

  1. Instructions or keyboard shortcuts to show autocomplete, etc
  2. Maybe it could be written more in a third-person voice. Right now it has several "I"'s which are fine and personal, but in terms of style, probably a third person format could be appropriate.

@squeedee
Copy link
Member Author

squeedee commented Feb 22, 2022

@davidmirror-ops

  1. Instructions or keyboard shortcuts to show autocomplete, etc

The instructions are in the help on the editor page
I do have plans to put them in an accordion box so they're more obvious, but this is an early draft and I don't want to keep sinking effort into it. They are there, and I think more useful on the page than in the blog post

  1. Maybe it could be written more in a third-person voice. Right now it has several "I"'s which are fine and personal, but in terms of style, probably a third person format could be appropriate.

I'm taking personal responsibility for this until it becomes formalized, so I feel this tone keeps it clear that folks will need to work with me (as the author of the page). Do you disagree?

@davidmirror-ops
Copy link
Contributor

/lgtm

Thanks Rash

@squeedee squeedee merged commit 1e9f3bb into main Feb 23, 2022
@squeedee squeedee deleted the experiment/live-editor branch February 23, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants