This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
[release-0.12] UC: raise logging level for some log messages #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises the level of some local path and other unmanaged cluster output that we don't want emitted by default for the Docker Desktop integration. It also raises the default verbosity of commands so even though these are logging at a higher level, they will still be printed in a normal run. This allows the Docker Desktop integration to explicitly run these calls with a lower verbosity and not include the messages. Signed-off-by: Sean McGinnis <smcginnis@vmware.com> (cherry picked from commit c1d8e96)
On cluster creation we print out steps explaining how to delete the cluster. This raises the log level on those messages so they are not printed when verbosity is set lower so things like the Docker Desktop integration where the default instructions do not apply. Signed-off-by: Sean McGinnis <smcginnis@vmware.com> (cherry picked from commit 416728b)
There were issues with the way log verbosity was being set which caused the incorrect level to be used, resulting in some expected lines not printing at the default log level. This updates the handling to correctly parse and set the level from the flag. Also some minor refactoring to make it a little easier to understand. Signed-off-by: Sean McGinnis <smcginnis@vmware.com> (cherry picked from commit e8d6612)
stmcginnis
changed the title
jpmcb
approved these changes
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
In order to hide some log output when used in the Docker Desktop extension, this
raises the log level of some of the messages referring to local paths so they can be
skipped at a lower verbosity level in the extension.