Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint to our golang build images #3087

Closed
antgamdia opened this issue Jul 5, 2021 · 0 comments · Fixed by #5045
Closed

Add golangci-lint to our golang build images #3087

antgamdia opened this issue Jul 5, 2021 · 0 comments · Fixed by #5045
Assignees
@antgamdia
Labels
component/ci Issue related to kubeapps ci system go Pull requests that update Go code kind/enhancement An issue that reports an enhancement for an implemented feature
Milestone
Technical debt

Comments

@antgamdia
Copy link
Contributor

We can use some linters to avoid some issues (like missing error catching)

https://github.com/golangci/golangci-lint
@antgamdia antgamdia added kind/enhancement An issue that reports an enhancement for an implemented feature priority/low go Pull requests that update Go code labels Jul 5, 2021
@ppbaena ppbaena added this to the 2021-Q2 milestone Jul 9, 2021
@antgamdia antgamdia mentioned this issue May 31, 2022
Closed
@ppbaena ppbaena added the component/ci Issue related to kubeapps ci system label Jun 8, 2022
This was referenced Jul 8, 2022
Merged
Merged
Merged
Merged
@antgamdia antgamdia self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antgamdia antgamdia

Labels
component/ci Issue related to kubeapps ci system go Pull requests that update Go code kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Kubeapps
Archived in project
Milestone
Technical debt
Development

Successfully merging a pull request may close this issue.

Add golangci-lint gh action vmware-tanzu/kubeapps
2 participants
@ppbaena @antgamdia